From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97236-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21598 invoked by alias); 19 Dec 2012 16:58:20 -0000
Received: (qmail 21590 invoked by uid 22791); 19 Dec 2012 16:58:19 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Dec 2012 16:58:11 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MFA00200F1E0N00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Wed, 19 Dec 2012 18:58:08 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFA00150F4WT2B0@a-mtaout21.012.net.il>; Wed, 19 Dec 2012 18:58:08 +0200 (IST)
Date: Wed, 19 Dec 2012 16:58:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] Require extern modifier for function prototypes in headers.
In-reply-to: <000001cddddb$7999a0a0$6ccce1e0$%muller@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r4mmnfm7.fsf@gnu.org>
References: <000001cddddb$7999a0a0$6ccce1e0$%muller@ics-cnrs.unistra.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00709.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Wed, 19 Dec 2012 12:24:56 +0100
> 
>  All external functions should have a declaration in a header file that
> -callers include, except for @code{_initialize_*} functions, which must
> +callers include, that declaration should use the @code{extern} modifier.
> +The only exception concerns @code{_initialize_*} functions, which must
>  be external so that @file{init.c} construction works, but shouldn't be
>  visible to random source files.

If all declarations must be external, the _initialize_* case is no
longer special, so the second sentence should go away, IMO.

Otherwise, OK with me.

Thanks.