From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Jan Kratochvil'" <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>, "'Eli Zaretskii'" <eliz@gnu.org>
Subject: RE: [RFC] Require extern modifier for function prototypes in headers.
Date: Sat, 22 Dec 2012 17:53:00 -0000 [thread overview]
Message-ID: <002d01cde06d$36ada860$a408f920$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20121222125347.GA6406@host2.jankratochvil.net>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Jan Kratochvil
> Envoyé : samedi 22 décembre 2012 13:54
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; 'Eli Zaretskii'
> Objet : Re: [RFC] Require extern modifier for function prototypes in
> headers.
>
> On Wed, 19 Dec 2012 12:24:56 +0100, Pierre Muller wrote:
> > Joel proposed that I added a change to GDB coding styles.
>
> It was me, that we do not put it into Joel's mouth.
Whoops, sorry for the mistake.
> On Wed, 19 Dec 2012 22:48:11 +0100, Pierre Muller wrote:
> > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > > owner@sourceware.org] De la part de Eli Zaretskii
> [...]
> > > If all declarations must be external, the _initialize_* case is no
> > > longer special, so the second sentence should go away, IMO.
> >
> > I thought that it was still special in the sense that they
> > are the only non-static functions that are not declared in headers,
> > but only inside the C source itself.
>
> I agree with the technical part said by Pierre here. So the doc change
> seems
> approved to me that way.
Thanks,
Patch applied in
http://sourceware.org/ml/gdb-cvs/2012-12/msg00174.html
Pierre Muller
prev parent reply other threads:[~2012-12-22 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000001cddddb$7999a0a0$6ccce1e0$%muller@ics-cnrs.unistra.fr>
2012-12-19 16:58 ` Eli Zaretskii
2012-12-19 21:48 ` Pierre Muller
2012-12-19 11:25 ` Pierre Muller
2012-12-22 12:54 ` Jan Kratochvil
2012-12-22 17:53 ` Pierre Muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002d01cde06d$36ada860$a408f920$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox