From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21928 invoked by alias); 22 Dec 2012 17:53:55 -0000 Received: (qmail 21920 invoked by uid 22791); 22 Dec 2012 17:53:54 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 22 Dec 2012 17:53:44 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBMHrEdD027365 ; Sat, 22 Dec 2012 18:53:14 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBMHrCnM031815 ; Sat, 22 Dec 2012 18:53:12 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBMHr91L000784 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Sat, 22 Dec 2012 18:53:10 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Jan Kratochvil'" Cc: , "'Eli Zaretskii'" References: <002201cdde32$8b3379b0$a19a6d10$@muller@ics-cnrs.unistra.fr> <000001cddddb$7999a0a0$6ccce1e0$@muller@ics-cnrs.unistra.fr> <20121222125347.GA6406@host2.jankratochvil.net> In-Reply-To: <20121222125347.GA6406@host2.jankratochvil.net> Subject: RE: [RFC] Require extern modifier for function prototypes in headers. Date: Sat, 22 Dec 2012 17:53:00 -0000 Message-ID: <002d01cde06d$36ada860$a408f920$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00782.txt.bz2 > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Jan Kratochvil > Envoy=C3=A9 : samedi 22 d=C3=A9cembre 2012 13:54 > =C3=80 : Pierre Muller > Cc : gdb-patches@sourceware.org; 'Eli Zaretskii' > Objet : Re: [RFC] Require extern modifier for function prototypes in > headers. >=20 > On Wed, 19 Dec 2012 12:24:56 +0100, Pierre Muller wrote: > > Joel proposed that I added a change to GDB coding styles. >=20 > It was me, that we do not put it into Joel's mouth. Whoops, sorry for the mistake. =20 > On Wed, 19 Dec 2012 22:48:11 +0100, Pierre Muller wrote: > > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > > owner@sourceware.org] De la part de Eli Zaretskii > [...] > > > If all declarations must be external, the _initialize_* case is no > > > longer special, so the second sentence should go away, IMO. > > > > I thought that it was still special in the sense that they > > are the only non-static functions that are not declared in headers, > > but only inside the C source itself. >=20 > I agree with the technical part said by Pierre here. So the doc change > seems > approved to me that way. Thanks, Patch applied in http://sourceware.org/ml/gdb-cvs/2012-12/msg00174.html Pierre Muller