From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] Add id of TSV into traceframe_info.
Date: Fri, 07 Jun 2013 14:39:00 -0000 [thread overview]
Message-ID: <83r4get27u.fsf@gnu.org> (raw)
In-Reply-To: <1370610493-26468-4-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Fri, 7 Jun 2013 21:08:11 +0800
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -91,6 +91,8 @@ show range-stepping
> the number of control packets from/to GDB. See "New remote packets"
> below.
>
> +* GDB now understands the element 'tvar' in the XML traceframe info.
> +
Shouldn't we tell what that element means or does?
> + ** GDBserver now adds element 'tvar' in the XML in the reply to
> + 'qXfer:traceframe-info:read'.
And here.
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -41790,17 +41790,27 @@ A region of collected memory starting at @var{addr} and extending for
> <memory start="@var{addr}" length="@var{length}"/>
> @end smallexample
>
> +@item
> +A block indicating trace state variable numbered @var{number} has been
> +collected:
> +
> +@smallexample
> +<tvar id="@var{number}"/>
> +@end smallexample
> +
> @end itemize
>
> The formal DTD for the traceframe info format is given below:
>
> @smallexample
> -<!ELEMENT traceframe-info (memory)* >
> +<!ELEMENT traceframe-info (memory | tvar)* >
> <!ATTLIST traceframe-info version CDATA #FIXED "1.0">
>
> <!ELEMENT memory EMPTY>
> <!ATTLIST memory start CDATA #REQUIRED
> length CDATA #REQUIRED>
> +<!ELEMENT tvar>
> +<!ATTLIST tvar id CDATA #REQUIRED>
> @end smallexample
This part is OK.
Thanks.
next prev parent reply other threads:[~2013-06-07 14:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 13:07 [PATCH 0/5] New MI command -trace-frame-collected Yao Qi
2013-06-07 13:07 ` [PATCH 5/5] New test: gdb.trace/mi-trace-frame-collected.exp Yao Qi
2013-06-07 13:07 ` [PATCH 2/5] Move code to get_traceframe_location Yao Qi
2013-06-07 21:09 ` Pedro Alves
2013-06-07 13:07 ` [PATCH 3/5] Add id of TSV into traceframe_info Yao Qi
2013-06-07 14:39 ` Eli Zaretskii [this message]
2013-06-08 11:06 ` Yao Qi
2013-06-07 13:07 ` [PATCH 1/5] Remove global variable tracepoint_list and stepping_list Yao Qi
2013-06-07 20:50 ` Pedro Alves
2013-06-07 13:07 ` [PATCH 4/5] New MI command -trace-frame-collected Yao Qi
2013-06-13 1:29 ` [PATCH 0/6 V2] " Yao Qi
2013-06-13 1:29 ` [PATCH 5/6] " Yao Qi
2013-06-13 14:27 ` Eli Zaretskii
2013-06-14 9:52 ` Yao Qi
2013-06-14 12:34 ` Eli Zaretskii
2013-06-17 10:21 ` Yao Qi
2013-06-17 15:48 ` Eli Zaretskii
2013-06-18 14:09 ` Yao Qi
2013-06-18 17:24 ` Eli Zaretskii
2013-06-25 17:31 ` Pedro Alves
2013-06-26 8:29 ` Yao Qi
2013-06-26 11:22 ` Pedro Alves
2013-06-13 1:29 ` [PATCH 2/6] Emit error in tdump command when traceframe is not selected Yao Qi
2013-06-25 15:32 ` Pedro Alves
2013-06-13 1:29 ` [PATCH 4/6] Add id of TSV into traceframe_info Yao Qi
2013-06-13 3:40 ` Eli Zaretskii
2013-06-25 16:18 ` Pedro Alves
2013-06-26 8:19 ` Yao Qi
2013-06-13 1:29 ` [PATCH 3/6] Move code to get_traceframe_location Yao Qi
2013-06-25 15:43 ` Pedro Alves
2013-06-13 1:29 ` [PATCH 6/6] New test: gdb.trace/mi-trace-frame-collected.exp Yao Qi
2013-06-25 18:42 ` Pedro Alves
2013-06-26 10:32 ` Yao Qi
2013-06-13 2:46 ` [PATCH 1/6] Remove global variable tracepoint_list and stepping_list Yao Qi
2013-06-25 15:28 ` Pedro Alves
2013-06-24 15:25 ` [ping]: [PATCH 0/6 V2] New MI command -trace-frame-collected Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r4get27u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox