From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-102273-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26889 invoked by alias); 7 Jun 2013 14:39:20 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 26878 invoked by uid 89); 7 Jun 2013 14:39:20 -0000
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 07 Jun 2013 14:39:18 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MO1000001YA7700@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 07 Jun 2013 17:39:16 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MO100NX221G3060@a-mtaout22.012.net.il>; Fri, 07 Jun 2013 17:39:16 +0300 (IDT)
Date: Fri, 07 Jun 2013 14:39:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 3/5] Add id of TSV into traceframe_info.
In-reply-to: <1370610493-26468-4-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r4get27u.fsf@gnu.org>
References: <1370610493-26468-1-git-send-email-yao@codesourcery.com> <1370610493-26468-4-git-send-email-yao@codesourcery.com>
X-SW-Source: 2013-06/txt/msg00157.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Fri, 7 Jun 2013 21:08:11 +0800
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -91,6 +91,8 @@ show range-stepping
>    the number of control packets from/to GDB.  See "New remote packets"
>    below.
>  
> +* GDB now understands the element 'tvar' in the XML traceframe info.
> +

Shouldn't we tell what that element means or does?

> +  ** GDBserver now adds element 'tvar' in the XML in the reply to
> +     'qXfer:traceframe-info:read'.

And here.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -41790,17 +41790,27 @@ A region of collected memory starting at @var{addr} and extending for
>  <memory start="@var{addr}" length="@var{length}"/>
>  @end smallexample
>  
> +@item
> +A block indicating trace state variable numbered @var{number} has been
> +collected:
> +
> +@smallexample
> +<tvar id="@var{number}"/>
> +@end smallexample
> +
>  @end itemize
>  
>  The formal DTD for the traceframe info format is given below:
>  
>  @smallexample
> -<!ELEMENT traceframe-info  (memory)* >
> +<!ELEMENT traceframe-info  (memory | tvar)* >
>  <!ATTLIST traceframe-info  version CDATA   #FIXED  "1.0">
>  
>  <!ELEMENT memory        EMPTY>
>  <!ATTLIST memory        start   CDATA   #REQUIRED
>                          length  CDATA   #REQUIRED>
> +<!ELEMENT tvar>
> +<!ATTLIST tvar          id      CDATA   #REQUIRED>
>  @end smallexample

This part is OK.

Thanks.