From: Eli Zaretskii <eliz@gnu.org>
To: tromey@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [review] Report GetLastError value when DebugActiveProcess fails
Date: Thu, 14 Nov 2019 16:54:00 -0000 [thread overview]
Message-ID: <83r22a4cwj.fsf@gnu.org> (raw)
In-Reply-To: <gerrit.1573749658000.Ie1bf502a0d96bb7c09bd5b1c5e0c924ba58cd68c@gnutoolchain-gerrit.osci.io>
> Date: Thu, 14 Nov 2019 11:40:58 -0500
> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>
> --- a/gdb/windows-nat.c
> +++ b/gdb/windows-nat.c
> @@ -1983,7 +1983,8 @@
> #endif
>
> if (!ok)
> - error (_("Can't attach to process."));
> + error (_("Can't attach to process %u (error %u)"),
> + (unsigned) pid, (unsigned) GetLastError ());
Why not show the text that corresponds to the error code? A lone code
is not very descriptive, IME.
next prev parent reply other threads:[~2019-11-14 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 16:41 Tom Tromey (Code Review)
2019-11-14 16:54 ` Eli Zaretskii [this message]
2019-11-14 16:58 ` Tom Tromey
2019-11-19 15:33 ` Tom Tromey (Code Review)
2019-11-19 15:38 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-19 15:38 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r22a4cwj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox