From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-160797-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 105261 invoked by alias); 14 Nov 2019 16:54:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 105249 invoked by uid 89); 14 Nov 2019 16:54:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 16:54:23 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55392)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1iVINx-0001o2-Lc; Thu, 14 Nov 2019 11:54:21 -0500
Received: from [176.228.60.248] (port=3048 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1iVINx-0003Lm-05; Thu, 14 Nov 2019 11:54:21 -0500
Date: Thu, 14 Nov 2019 16:54:00 -0000
Message-Id: <83r22a4cwj.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: tromey@sourceware.org, gdb-patches@sourceware.org
In-reply-to:	<gerrit.1573749658000.Ie1bf502a0d96bb7c09bd5b1c5e0c924ba58cd68c@gnutoolchain-gerrit.osci.io>
Subject: Re: [review] Report GetLastError value when DebugActiveProcess fails
References: <gerrit.1573749658000.Ie1bf502a0d96bb7c09bd5b1c5e0c924ba58cd68c@gnutoolchain-gerrit.osci.io> <gerrit.1573749658000.Ie1bf502a0d96bb7c09bd5b1c5e0c924ba58cd68c@gnutoolchain-gerrit.osci.io>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-11/txt/msg00395.txt.bz2

> Date: Thu, 14 Nov 2019 11:40:58 -0500
> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
> 
> --- a/gdb/windows-nat.c
> +++ b/gdb/windows-nat.c
> @@ -1983,7 +1983,8 @@
>  #endif
>  
>    if (!ok)
> -    error (_("Can't attach to process."));
> +    error (_("Can't attach to process %u (error %u)"),
> +	   (unsigned) pid, (unsigned) GetLastError ());

Why not show the text that corresponds to the error code?  A lone code
is not very descriptive, IME.