Re: [review] Report GetLastError value when DebugActiveProcess fails

[Tom Tromey <tom@tromey.com>]

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Thu, 14 Nov 2019 11:40:58 -0500
>> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>> 
>> --- a/gdb/windows-nat.c
>> +++ b/gdb/windows-nat.c
>> @@ -1983,7 +1983,8 @@
>> #endif
>> 
>> if (!ok)
>> -    error (_("Can't attach to process."));
>> +    error (_("Can't attach to process %u (error %u)"),
>> +	   (unsigned) pid, (unsigned) GetLastError ());

Eli> Why not show the text that corresponds to the error code?  A lone code
Eli> is not very descriptive, IME.

I plan to do that in the future.  I didn't do it yet because there's no
convenient way to do it (there's a helper function in gdbserver but not
gdb; but maybe we're going to use some gnulib thing instead?); and
because doing a good job would mean fixing all such calls in
windows-nat.c.

Meanwhile, I needed this one.

Tom