Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATH] Honor $INSIDE_EMACS, not only $EMACS.
Date: Thu, 29 Oct 2015 17:50:00 -0000	[thread overview]
Message-ID: <83pozx1t53.fsf@gnu.org> (raw)
In-Reply-To: <56324E6A.3070003@redhat.com>

> Date: Thu, 29 Oct 2015 16:50:50 +0000
> From: Pedro Alves <palves@redhat.com>
> 
> > diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> > index 66f6dd6..63a217f 100644
> > --- a/gdb/ChangeLog
> > +++ b/gdb/ChangeLog
> > @@ -1,3 +1,9 @@
> > +2015-10-29  Eli Zaretskii  <eliz@gnu.org>
> > +
> > +	* utils.c (init_page_info): Disable paging if INSIDE_EMACS is set
> > +	in the environment.  Emacs 25 and later uses that variable instead
> > +	of EMACS.
> 
> The last sentence ("25 and later") ...
> 
> > --- a/gdb/utils.c
> > +++ b/gdb/utils.c
> > @@ -1677,8 +1677,8 @@ init_page_info (void)
> >           Only try to use tgetnum function if rl_get_screen_size
> >           did not return a useful value. */
> >        if (((rows <= 0) && (tgetnum ("li") < 0))
> > -	/* Also disable paging if inside EMACS.  */
> > -	  || getenv ("EMACS"))
> > +	/* Also disable paging if inside Emacs.  */
> > +	  || getenv ("EMACS") || getenv ("INSIDE_EMACS"))
> >  	{
> 
> ... would be better moved to the comment here instead.
> 
> LGTM with that change.

Thanks, pushed.


      reply	other threads:[~2015-10-29 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 17:10 Eli Zaretskii
2015-10-29 17:10 ` Pedro Alves
2015-10-29 17:50   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pozx1t53.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox