From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127155-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13147 invoked by alias); 29 Oct 2015 17:28:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13081 invoked by uid 89); 29 Oct 2015 17:28:26 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout29.012.net.il
Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Oct 2015 17:28:24 +0000
Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NWZ00C00S715L00@mtaout29.012.net.il> for gdb-patches@sourceware.org; Thu, 29 Oct 2015 19:27:44 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWZ00C8RSI87U10@mtaout29.012.net.il>; Thu, 29 Oct 2015 19:27:44 +0200 (IST)
Date: Thu, 29 Oct 2015 17:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATH] Honor $INSIDE_EMACS, not only $EMACS.
In-reply-to: <56324E6A.3070003@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83pozx1t53.fsf@gnu.org>
References: <83r3kd1v16.fsf@gnu.org> <56324E6A.3070003@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2015-10/txt/msg00719.txt.bz2

> Date: Thu, 29 Oct 2015 16:50:50 +0000
> From: Pedro Alves <palves@redhat.com>
> 
> > diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> > index 66f6dd6..63a217f 100644
> > --- a/gdb/ChangeLog
> > +++ b/gdb/ChangeLog
> > @@ -1,3 +1,9 @@
> > +2015-10-29  Eli Zaretskii  <eliz@gnu.org>
> > +
> > +	* utils.c (init_page_info): Disable paging if INSIDE_EMACS is set
> > +	in the environment.  Emacs 25 and later uses that variable instead
> > +	of EMACS.
> 
> The last sentence ("25 and later") ...
> 
> > --- a/gdb/utils.c
> > +++ b/gdb/utils.c
> > @@ -1677,8 +1677,8 @@ init_page_info (void)
> >           Only try to use tgetnum function if rl_get_screen_size
> >           did not return a useful value. */
> >        if (((rows <= 0) && (tgetnum ("li") < 0))
> > -	/* Also disable paging if inside EMACS.  */
> > -	  || getenv ("EMACS"))
> > +	/* Also disable paging if inside Emacs.  */
> > +	  || getenv ("EMACS") || getenv ("INSIDE_EMACS"))
> >  	{
> 
> ... would be better moved to the comment here instead.
> 
> LGTM with that change.

Thanks, pushed.