From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: noreply@gnutoolchain-gerrit.osci.io, simon.marchi@polymtl.ca,
tromey@sourceware.org, palves@redhat.com, brobecker@adacore.com,
kevinb@redhat.com, gdb-patches@sourceware.org
Subject: Re: [pushed] gdb: Support printf 'z' size modifier
Date: Thu, 14 Nov 2019 16:59:00 -0000 [thread overview]
Message-ID: <83pnhu4co3.fsf@gnu.org> (raw)
In-Reply-To: <20191114164945.GP11037@embecosm.com> (message from Andrew Burgess on Thu, 14 Nov 2019 16:49:45 +0000)
> Date: Thu, 14 Nov 2019 16:49:45 +0000
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: noreply@gnutoolchain-gerrit.osci.io, simon.marchi@polymtl.ca,
> tromey@sourceware.org, palves@redhat.com, brobecker@adacore.com,
> kevinb@redhat.com, gdb-patches@sourceware.org
>
> I guess there are a couple of solutions:
>
> 1. Remove all uses of %z from GDB, and back out the %z support, or
>
> 2. Have GDB translate %z into some other suitable format specifier
> for targets where %z is not supported.
>
> Below is a patch that tries to take the second approach.
Hmm... isn't it better to simply add -D__USE_MINGW_ANSI_STDIO=1 to the
cpp flags when building with MinGW? I don't think there are versions
of MinGW that don't support that macro.
The effect of that macro is to link against a MinGW library that
provides replacement implementations for *printf functions, and the
replacements do support %z.
next prev parent reply other threads:[~2019-11-14 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 15:46 [review] " Andrew Burgess (Code Review)
2019-11-05 16:22 ` Tom Tromey (Code Review)
2019-11-05 16:31 ` Simon Marchi (Code Review)
2019-11-06 0:18 ` Pedro Alves (Code Review)
2019-11-07 10:59 ` [review v2] " Andrew Burgess (Code Review)
2019-11-07 11:05 ` Andrew Burgess (Code Review)
2019-11-12 20:19 ` Kevin Buettner (Code Review)
2019-11-12 23:53 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 23:53 ` Sourceware to Gerrit sync (Code Review)
2019-11-14 12:55 ` Eli Zaretskii
2019-11-14 16:49 ` Andrew Burgess
2019-11-14 16:59 ` Eli Zaretskii [this message]
2019-11-14 17:09 ` Simon Marchi
2019-11-14 18:27 ` Eli Zaretskii
2019-11-14 20:37 ` Pedro Alves
2019-11-15 7:37 ` Eli Zaretskii
2019-11-14 17:06 ` Pedro Alves
2019-11-14 18:18 ` Eli Zaretskii
2019-11-14 21:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnhu4co3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=noreply@gnutoolchain-gerrit.osci.io \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox