From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
simon.marchi@polymtl.ca, tromey@sourceware.org,
palves@redhat.com, brobecker@adacore.com, kevinb@redhat.com,
gdb-patches@sourceware.org
Subject: Re: [pushed] gdb: Support printf 'z' size modifier
Date: Thu, 14 Nov 2019 21:27:00 -0000 [thread overview]
Message-ID: <87a78y1778.fsf@tromey.com> (raw)
In-Reply-To: <20191114164945.GP11037@embecosm.com> (Andrew Burgess's message of "Thu, 14 Nov 2019 16:49:45 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> For the long long case we might also translate to %I64d if
Andrew> USE_PRINTF_I64 is true.
FWIW, today I debugged a crash on an internal test case that turned out
to happen because format_pieces does not recognize %I64d, but format.c
also already changes %lld to %I64d.
So, we need to handle something here. I am leaning toward just teaching
format.c about %I64d as well.
Tom
prev parent reply other threads:[~2019-11-14 21:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 15:46 [review] " Andrew Burgess (Code Review)
2019-11-05 16:22 ` Tom Tromey (Code Review)
2019-11-05 16:31 ` Simon Marchi (Code Review)
2019-11-06 0:18 ` Pedro Alves (Code Review)
2019-11-07 10:59 ` [review v2] " Andrew Burgess (Code Review)
2019-11-07 11:05 ` Andrew Burgess (Code Review)
2019-11-12 20:19 ` Kevin Buettner (Code Review)
2019-11-12 23:53 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 23:53 ` Sourceware to Gerrit sync (Code Review)
2019-11-14 12:55 ` Eli Zaretskii
2019-11-14 16:49 ` Andrew Burgess
2019-11-14 16:59 ` Eli Zaretskii
2019-11-14 17:09 ` Simon Marchi
2019-11-14 18:27 ` Eli Zaretskii
2019-11-14 20:37 ` Pedro Alves
2019-11-15 7:37 ` Eli Zaretskii
2019-11-14 17:06 ` Pedro Alves
2019-11-14 18:18 ` Eli Zaretskii
2019-11-14 21:27 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a78y1778.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox