From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111476 invoked by alias); 14 Nov 2019 16:59:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111459 invoked by uid 89); 14 Nov 2019 16:59:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:960 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 16:59:29 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVISr-000598-FI; Thu, 14 Nov 2019 11:59:25 -0500 Received: from [176.228.60.248] (port=3352 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVISq-0001FC-H4; Thu, 14 Nov 2019 11:59:25 -0500 Date: Thu, 14 Nov 2019 16:59:00 -0000 Message-Id: <83pnhu4co3.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess CC: noreply@gnutoolchain-gerrit.osci.io, simon.marchi@polymtl.ca, tromey@sourceware.org, palves@redhat.com, brobecker@adacore.com, kevinb@redhat.com, gdb-patches@sourceware.org In-reply-to: <20191114164945.GP11037@embecosm.com> (message from Andrew Burgess on Thu, 14 Nov 2019 16:49:45 +0000) Subject: Re: [pushed] gdb: Support printf 'z' size modifier References: <20191112235315.5BD6728171@gnutoolchain-gerrit.osci.io> <83y2wi62jp.fsf@gnu.org> <20191114164945.GP11037@embecosm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00397.txt.bz2 > Date: Thu, 14 Nov 2019 16:49:45 +0000 > From: Andrew Burgess > Cc: noreply@gnutoolchain-gerrit.osci.io, simon.marchi@polymtl.ca, > tromey@sourceware.org, palves@redhat.com, brobecker@adacore.com, > kevinb@redhat.com, gdb-patches@sourceware.org > > I guess there are a couple of solutions: > > 1. Remove all uses of %z from GDB, and back out the %z support, or > > 2. Have GDB translate %z into some other suitable format specifier > for targets where %z is not supported. > > Below is a patch that tries to take the second approach. Hmm... isn't it better to simply add -D__USE_MINGW_ANSI_STDIO=1 to the cpp flags when building with MinGW? I don't think there are versions of MinGW that don't support that macro. The effect of that macro is to link against a MinGW library that provides replacement implementations for *printf functions, and the replacements do support %z.