Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com,
	brobecker@adacore.com
Subject: Re: [patch 1/3]  Implement support for PowerPC BookE masked watchpoints
Date: Fri, 26 Nov 2010 10:57:00 -0000	[thread overview]
Message-ID: <83oc9c73me.fsf@gnu.org> (raw)
In-Reply-To: <1290548544.3164.37.camel@hactar>

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,        Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 23 Nov 2010 19:42:24 -0200
> 
> I broke up the patch I submitted previously as "[patch 2/2] Implement
> support for PowerPC BookE masked and ranged watchpoints" into the three
> patches in this series. The first adds masked watchpoint support, the
> second adds ranged watchpoints support (without the watch-range command)
> and the third adds the polemic watch-range command.
> 
> This patch is a bigger than the others because it has to add code to
> handle the new target methods extra_resources_needed,
> works_in_software_mode and print_one_detail. The code is the same as
> what was already reviewed though, except for fixing the GNU style
> regarding whitespace in ppc_linux_{insert,remove}_mask_watchpoint.
> 
> I changed a bit the wording of the paragraph mentioning masked
> watchpoint support in the NEWS file, and also added a "Changed Commands"
> section so the NEWS entry needs another review.  The manual part is the
> same except for omitting the sentences about ranged watchpoint support.
> 
> Ok to commit?

Correct me if I'm wrong, but since I already reviewed and approved the
documentation changes in this patch (and other parts thereof), there's
no need for me to review it again in parts, right?


  reply	other threads:[~2010-11-26 10:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 21:43 Thiago Jung Bauermann
2010-11-26 10:57 ` Eli Zaretskii [this message]
2010-11-27 13:29   ` Thiago Jung Bauermann
2010-11-27 15:27     ` Eli Zaretskii
2010-12-23 19:31 ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83oc9c73me.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bauerman@br.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox