From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22396 invoked by alias); 26 Nov 2010 10:57:08 -0000 Received: (qmail 22384 invoked by uid 22791); 26 Nov 2010 10:57:07 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Nov 2010 10:57:02 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LCH00500NICSX00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 26 Nov 2010 12:56:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.63.39]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LCH005PWNQHBJ60@a-mtaout20.012.net.il>; Fri, 26 Nov 2010 12:56:43 +0200 (IST) Date: Fri, 26 Nov 2010 10:57:00 -0000 From: Eli Zaretskii Subject: Re: [patch 1/3] Implement support for PowerPC BookE masked watchpoints In-reply-to: <1290548544.3164.37.camel@hactar> To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, brobecker@adacore.com Reply-to: Eli Zaretskii Message-id: <83oc9c73me.fsf@gnu.org> References: <1290548544.3164.37.camel@hactar> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00447.txt.bz2 > From: Thiago Jung Bauermann > Cc: Jan Kratochvil , Joel Brobecker , Eli Zaretskii > Date: Tue, 23 Nov 2010 19:42:24 -0200 > > I broke up the patch I submitted previously as "[patch 2/2] Implement > support for PowerPC BookE masked and ranged watchpoints" into the three > patches in this series. The first adds masked watchpoint support, the > second adds ranged watchpoints support (without the watch-range command) > and the third adds the polemic watch-range command. > > This patch is a bigger than the others because it has to add code to > handle the new target methods extra_resources_needed, > works_in_software_mode and print_one_detail. The code is the same as > what was already reviewed though, except for fixing the GNU style > regarding whitespace in ppc_linux_{insert,remove}_mask_watchpoint. > > I changed a bit the wording of the paragraph mentioning masked > watchpoint support in the NEWS file, and also added a "Changed Commands" > section so the NEWS entry needs another review. The manual part is the > same except for omitting the sentences about ranged watchpoint support. > > Ok to commit? Correct me if I'm wrong, but since I already reviewed and approved the documentation changes in this patch (and other parts thereof), there's no need for me to review it again in parts, right?