Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com,
	brobecker@adacore.com
Subject: Re: [patch 1/3]  Implement support for PowerPC BookE masked watchpoints
Date: Sat, 27 Nov 2010 15:27:00 -0000	[thread overview]
Message-ID: <83ipzi6azz.fsf@gnu.org> (raw)
In-Reply-To: <1290864564.3009.45.camel@hactar>

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com,
>         brobecker@adacore.com
> Date: Sat, 27 Nov 2010 11:29:24 -0200
> 
> I just wanted to make sure that you're happy with the wording in this
> paragraph:
> 
> +* When locally debugging programs on PowerPC BookE processors running
> +  a Linux kernel version 2.6.34 or later GDB supports masked hardware
> +  watchpoints, which specifiy a mask in addition to an address to watch.
> +  The mask specifies that some bits of an address (the bits which are
> +  reset in the mask) should be ignored when matching the address accessed
> +  by the inferior against the watchpoint address.  See the "PowerPC Embedded"
> +  section in the user manual for more details.

I'm okay with it, but please put a comma after "or later".

> and also with the new "Changed commands" section that I added.

This section is fine.

Thanks.


  reply	other threads:[~2010-11-27 15:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 21:43 Thiago Jung Bauermann
2010-11-26 10:57 ` Eli Zaretskii
2010-11-27 13:29   ` Thiago Jung Bauermann
2010-11-27 15:27     ` Eli Zaretskii [this message]
2010-12-23 19:31 ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ipzi6azz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bauerman@br.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox