From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76709-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4237 invoked by alias); 27 Nov 2010 15:27:21 -0000
Received: (qmail 4078 invoked by uid 22791); 27 Nov 2010 15:27:20 -0000
X-SWARE-Spam-Status: No, hits=-0.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 27 Nov 2010 15:27:14 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LCJ00100UNJRY00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 27 Nov 2010 17:27:12 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.229.63.39]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LCJ0013YUXAKT70@a-mtaout21.012.net.il>; Sat, 27 Nov 2010 17:27:12 +0200 (IST)
Date: Sat, 27 Nov 2010 15:27:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch 1/3]  Implement support for PowerPC BookE masked watchpoints
In-reply-to: <1290864564.3009.45.camel@hactar>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, brobecker@adacore.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ipzi6azz.fsf@gnu.org>
References: <1290548544.3164.37.camel@hactar> <83oc9c73me.fsf@gnu.org> <1290864564.3009.45.camel@hactar>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00466.txt.bz2

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com,
>         brobecker@adacore.com
> Date: Sat, 27 Nov 2010 11:29:24 -0200
> 
> I just wanted to make sure that you're happy with the wording in this
> paragraph:
> 
> +* When locally debugging programs on PowerPC BookE processors running
> +  a Linux kernel version 2.6.34 or later GDB supports masked hardware
> +  watchpoints, which specifiy a mask in addition to an address to watch.
> +  The mask specifies that some bits of an address (the bits which are
> +  reset in the mask) should be ignored when matching the address accessed
> +  by the inferior against the watchpoint address.  See the "PowerPC Embedded"
> +  section in the user manual for more details.

I'm okay with it, but please put a comma after "or later".

> and also with the new "Changed commands" section that I added.

This section is fine.

Thanks.