[commit] Fix fnchange.lst

[commit] Fix fnchange.lst

[Eli Zaretskii]

Would it be a good idea to run the ARI script when tarring a
pre-release or a release?  Too many files were clashing after 8+3
truncation.

Committed.

2009-09-19  Eli Zaretskii  <eliz@gnu.org>

	* config/djgpp/fnchange.lst: Add missing edits.

Index: gdb/config/djgpp/fnchange.lst
===================================================================
RCS file: /cvs/src/src/gdb/config/djgpp/fnchange.lst,v
retrieving revision 1.103
diff -u -r1.103 fnchange.lst
--- gdb/config/djgpp/fnchange.lst	31 Jul 2009 15:23:20 -0000	1.103
+++ gdb/config/djgpp/fnchange.lst	19 Sep 2009 09:45:22 -0000
@@ -40,6 +40,7 @@
 @V@/bfd/elf32-m68hc12.c @V@/bfd/em68hc12.c
 @V@/bfd/elf32-m68hc1x.c @V@/bfd/em68hc1x.c
 @V@/bfd/elf32-m68k.c @V@/bfd/em68k.c
+@V@/bfd/elf32-microblaze.c @V@/bfd/emicroblaze.c
 @V@/bfd/elf32-ppc.c @V@/bfd/e32ppc.c
 @V@/bfd/elf32-sh.c @V@/bfd/e32sh.c
 @V@/bfd/elf32-score.c @V@/bfd/e32score.c
@@ -52,6 +53,14 @@
 @V@/bfd/elf32-spu.c @V@/bfd/e32spu.c
 @V@/bfd/elf64-alpha.c @V@/bfd/e64alphf.c
 @V@/bfd/elf64-sh64.c @V@/bfd/e64sh64.c
+@V@/config/bootstrap-O1.mk @V@/config/boot-O1.mk
+@V@/config/bootstrap-O3.mk @V@/config/boot-O3.mk
+@V@/config/bootstrap-debug-big.mk @V@/config/boot-dbig.mk
+@V@/config/bootstrap-debug-ckovw.mk @V@/config/boot-bckovw.mk
+@V@/config/bootstrap-debug-lean.mk @V@/config/boot-dlean.mk
+@V@/config/bootstrap-debug-lib.mk @V@/config/boot-dlib.mk
+@V@/config/bootstrap-debug.mk @V@/config/boot-debug.mk
+@V@/config/bootstrap-time.mk @V@/config/boot-time.mk
 @V@/config/inttypes-pri.m4 @V@/config/pri-inttypes.m4
 @V@/config/inttypes_h.m4 @V@/config/uintmax-inttypes.m4
 @V@/config/mt-mips-elfoabi @V@/config/mt-elfoabi-mips
@@ -139,6 +148,16 @@
 @V@/gdb/darwin-nat.c @V@/gdb/drw-nat.c
 @V@/gdb/darwin-nat-info.c @V@/gdb/drw-nat-info.c
 @V@/gdb/features/mips64-cp0.xml @V@/gdb/features/mips64-0cp.xml
+@V@/gdb/features/arm-vfpv2.xml @V@/gdb/features/armvfpv2.xml
+@V@/gdb/features/arm-vfpv3.xml @V@/gdb/features/armvfpv3.xml
+@V@/gdb/features/arm-with-iwmmxt.xml @V@/gdb/features/arm-iwmmxt.xml
+@V@/gdb/features/arm-with-neon.xml @V@/gdb/features/arm-neon.xml
+@V@/gdb/features/arm-with-iwmmxt.c @V@/gdb/features/arm-iwmmxt.c
+@V@/gdb/features/arm-with-neon.c @V@/gdb/features/arm-neon.c
+@V@/gdb/features/arm-with-vfpv2.xml @V@/gdb/features/arm-wv2.xml
+@V@/gdb/features/arm-with-vfpv3.xml @V@/gdb/features/arm-wv3.xml
+@V@/gdb/features/arm-with-vfpv2.c @V@/gdb/features/arm-wv2.c
+@V@/gdb/features/arm-with-vfpv3.c @V@/gdb/features/arm-wv3.c
 @V@/gdb/features/rs6000/power-fpu-isa205.xml @V@/gdb/features/rs6000/power-isa205.xml
 @V@/gdb/features/rs6000/power64-core.xml @V@/gdb/features/rs6000/power64core.xml
 @V@/gdb/features/rs6000/power64-linux.xml @V@/gdb/features/rs6000/power64linux.xml
@@ -278,6 +297,10 @@
 @V@/gdb/ppcnbsd-tdep.c @V@/gdb/ppcnb-tdep.c
 @V@/gdb/ppcobsd-nat.c @V@/gdb/ppcob-nat.c
 @V@/gdb/ppcobsd-tdep.c @V@/gdb/ppcob-tdep.c
+@V@/gdb/regformats/arm-with-vfpv2.dat @V@/gdb/regformats/arm-wv2.dat
+@V@/gdb/regformats/arm-with-vfpv3.dat @V@/gdb/regformats/arm-wv3.dat
+@V@/gdb/regformats/arm-with-iwmmxt.dat @V@/gdb/regformats/arm-iwmmxt.dat
+@V@/gdb/regformats/arm-with-neon.dat @V@/gdb/regformats/arm-neon.dat
 @V@/gdb/regformats/reg-i386-linux.dat @V@/gdb/regformats/r-i386-lnx.dat
 @V@/gdb/regformats/reg-x86-64-linux.dat @V@/gdb/regformats/r-x8664-linux.dat
 @V@/gdb/regformats/reg-x86-64.dat @V@/gdb/regformats/r-x8664.dat
@@ -362,6 +385,8 @@
 @V@/gdb/testsuite/gdb.base/solib-display-main.exp @V@/gdb/testsuite/gdb.base/so-dispmain.exp
 @V@/gdb/testsuite/gdb.base/solib-symbol-lib.c @V@/gdb/testsuite/gdb.base/so-symlib.c
 @V@/gdb/testsuite/gdb.base/solib-symbol-main.c @V@/gdb/testsuite/gdb.base/so-symmain.c
+@V@/gdb/testsuite/gdb.base/solib-overlap-lib.c @V@/gdb/testsuite/gdb.base/so-ovrlib.c
+@V@/gdb/testsuite/gdb.base/solib-overlap-main.c @V@/gdb/testsuite/gdb.base/so-ovrmain.c
 @V@/gdb/testsuite/gdb.base/type-opaque-lib.c @V@/gdb/testsuite/gdb.base/ty-opqlib.c
 @V@/gdb/testsuite/gdb.base/type-opaque-main.c @V@/gdb/testsuite/gdb.base/ty-opqmain.c
 @V@/gdb/testsuite/gdb.base/watchpoint-hw.c @V@/gdb/testsuite/gdb.base/wp-hw.c
@@ -369,8 +394,15 @@
 @V@/gdb/testsuite/gdb.base/watchpoint-solib.c @V@/gdb/testsuite/gdb.base/wp-solib.c
 @V@/gdb/testsuite/gdb.base/watchpoint-hw.exp @V@/gdb/testsuite/gdb.base/wp-hw.exp
 @V@/gdb/testsuite/gdb.base/watchpoint-solib.exp @V@/gdb/testsuite/gdb.base/wp-solib.exp
+@V@/gdb/testsuite/gdb.cell/coremaker-spu.c @V@/gdb/testsuite/gdb.cell/core-spu.c
+@V@/gdb/testsuite/gdb.cell/ea-cache-spu.c @V@/gdb/testsuite/gdb.cell/ea-spu.c
+@V@/gdb/testsuite/gdb.cell/mem-access-spu.c @V@/gdb/testsuite/gdb.cell/mem-spu.c
 @V@/gdb/testsuite/gdb.cp/m-static1.cc @V@/gdb/testsuite/gdb.cp/m-stat1.cc
 @V@/gdb/testsuite/gdb.cp/namespace1.cc @V@/gdb/testsuite/gdb.cp/namesp1.cc
+@V@/gdb/testsuite/gdb.cp/namespace-nested-import.cc @V@/gdb/testsuite/gdb.cp/nnested.cc
+@V@/gdb/testsuite/gdb.cp/namespace-using.cc @V@/gdb/testsuite/gdb.cp/nusing.cc
+@V@/gdb/testsuite/gdb.cp/namespace-nested-import.exp @V@/gdb/testsuite/gdb.cp/nnested.exp
+@V@/gdb/testsuite/gdb.cp/namespace-using.exp @V@/gdb/testsuite/gdb.cp/nusing.exp
 @V@/gdb/testsuite/gdb.cp/mb-inline1.cc @V@/gdb/testsuite/gdb.cp/mb-inln1.cc
 @V@/gdb/testsuite/gdb.cp/mb-inline2.cc @V@/gdb/testsuite/gdb.cp/mb-inln2.cc
 @V@/gdb/testsuite/gdb.dwarf2/dw2-intermix.exp @V@/gdb/testsuite/gdb.dwarf2/dw2-intmix.exp
@@ -418,6 +450,10 @@
 @V@/gdb/testsuite/gdb.mi/mi2-var-child.exp @V@/gdb/testsuite/gdb.mi/mi2varchild.exp
 @V@/gdb/testsuite/gdb.mi/mi2-var-cmd.exp @V@/gdb/testsuite/gdb.mi/mi2varcmd.exp
 @V@/gdb/testsuite/gdb.mi/mi2-var-display.exp @V@/gdb/testsuite/gdb.mi/mi2vardisplay.exp
+@V@/gdb/testsuite/gdb.mi/mi-nonstop-exit.exp @V@/gdb/testsuite/gdb.mi/minonstop-exit.exp
+@V@/gdb/testsuite/gdb.mi/non-stop-exit.c @V@/gdb/testsuite/gdb.mi/nonstop-exit.c
+@V@/gdb/testsuite/gdb.threads/watchthreads2.c @V@/gdb/testsuite/gdb.threads/watchth2.c
+@V@/gdb/testsuite/gdb.threads/watchthreads2.exp @V@/gdb/testsuite/gdb.threads/watchth2.exp
 @V@/gdb/amd64-linux-tdep.c @V@/gdb/amd64-ltdep.c
 @V@/gdb/amd64-linux-nat.c @V@/gdb/amd64-lnat.c
 @V@/gdb/hppa-linux-tdep.c @V@/gdb/palnxtdep.c
@@ -477,6 +513,8 @@
 @V@/opcodes/iq2000-dis.c @V@/opcodes/iq2000dis.c
 @V@/opcodes/m68hc11-dis.c @V@/opcodes/m68hc11dis.c
 @V@/opcodes/m68hc11-opc.c @V@/opcodes/m68hc11opc.c
+@V@/opcodes/microblaze-opc.h @V@/opcodes/mbl-opc.h
+@V@/opcodes/microblaze-opcm.h @V@/opcodes/mbl-opcm.h
 @V@/opcodes/openrisc-asm.c @V@/opcodes/orisc-asm.c
 @V@/opcodes/openrisc-desc.c @V@/opcodes/orisc-desc.c
 @V@/opcodes/openrisc-dis.c @V@/opcodes/orisc-dis.c

Re: [commit] Fix fnchange.lst

[Joel Brobecker]

> Would it be a good idea to run the ARI script when tarring a
> pre-release or a release?  Too many files were clashing after 8+3
> truncation.

I don't think that this _needs_ to be part of the release process.
If we monitored the ARI results daily (I think that Pierre is doing
that for us right now, but it looks like doschk checks are not included
in the email), we shouldn't have this sort of issue. In the meantime,
we can just make sure we check the ARI on the web just before we cut
the branch, and maybe just before we create the release tarball.

If someone extracts out the script that does "dos checking" in
the ARI script, and returns a textual list of files that cause
problem, I don't mind adding it to the release procedure.

-- 
Joel

Re: [commit] Fix fnchange.lst

[Eli Zaretskii]

> Date: Sat, 19 Sep 2009 08:57:50 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > Would it be a good idea to run the ARI script when tarring a
> > pre-release or a release?  Too many files were clashing after 8+3
> > truncation.
> 
> I don't think that this _needs_ to be part of the release process.
> If we monitored the ARI results daily (I think that Pierre is doing
> that for us right now, but it looks like doschk checks are not included
> in the email), we shouldn't have this sort of issue.

While it's not fatal to have these issues exist on the trunk during
development, having them in a tarball is really bad.  That's why I
won't even dream of insisting that ARE results are monitored daily.
But I do think we should re-check this before a tarball is released.

> If someone extracts out the script that does "dos checking" in
> the ARI script, and returns a textual list of files that cause
> problem, I don't mind adding it to the release procedure.

If Pierre can do that, fine.  If not, if someone can tell me where do
I download the ARI script, I will give it a try.

Thanks.

Re: [commit] Fix fnchange.lst

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

> But I do think we should re-check this before a tarball is released.

Doing so a couple of days before a schedule release is indeed
reasonable; it avoids last second surprises.  We have the ARI results
published daily for the branch at:

    http://www.sourceware.org/gdb/ari/

I see there are 10 warnings remaining. Are these actually fixable?
I don't quite understand what the warnings say, because I can't find
files such as decimal1.h, for instance.

> > If someone extracts out the script that does "dos checking" in
> > the ARI script, and returns a textual list of files that cause
> > problem, I don't mind adding it to the release procedure.
> 
> If Pierre can do that, fine.  If not, if someone can tell me where do
> I download the ARI script, I will give it a try.

There is an "ss" repository that's owned by gdbadmin on sourceware:

    % cvs -d sourceware.org:/cvs/gdbadmin co ss

The only file that I found that made references to fnchange.lst is
update-web-ari.  There is a section of the script that uses that file
and emits the appropriate warnings for the ARI.

I don't think you'll have write priviledges. If you want, I can add
your key to the authorized_keys, or I can commit the changes for you.
Although, my advice would be to make the new script a part of the GDB
tarball.  That way, anyone can run the script, instead of just those
who log on sourceware.org.

-- 
Joel

[-- Attachment #2: update-web-ari --]
[-- Type: text/plain, Size: 23182 bytes --]

#!/bin/sh -x

# TODO: setjmp.h, setjmp and longjmp.


PATH=/bin:/usr/bin:/usr/local/bin:$HOME/bin
export PATH

# Direct stderr into stdout but still hang onto stderr (/dev/fd/3)
exec 3>&2 2>&1
ECHO ()
{
#   echo "$@" | tee /dev/fd/3 1>&2
    echo "$@" 1>&2
    echo "$@" 1>&3
}

# Really mindless usage
if test $# -ne 4
then
    echo "Usage: $0 <snapshot> <tmpdir> <destdir> <project>" 1>&2
    exit 1
fi
snapshot=$1 ; shift
tmpdir=$1 ; shift
wwwdir=$1 ; shift
project=$1 ; shift

if [ ! -w ${wwwdir} -o ! -d ${wwwdir} ]
then
  echo ERROR: Can not write to directory ${wwwdir} >&2
  exit 2
fi

if [ ! -r ${snapshot} ]
then
    echo ERROR: Can not read snapshot file 1>&2
    exit 1
fi

# FILE formats
# ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
# ari.*.idx: <BUG>:<FILE>:<CATEGORY>
# ari.*.doc: <BUG>:<COUNT>:<CATEGORY>:<DOC>
# Where ``*'' is {source,warning,indent,doschk}

unpack_source_p=true
delete_source_p=true

check_warning_p=false # broken
check_indent_p=false # too slow, too many fail
check_source_p=true
check_doschk_p=true
check_werror_p=true

update_doc_p=true
update_web_p=true


if awk --version 2>&1 </dev/null | grep -i gnu > /dev/null
then
  AWK=awk
else
  AWK=gawk
fi


# Set up a few cleanups
if ${delete_source_p}
then
    trap "cd /tmp; rm -rf ${tmpdir}; exit" 0 1 2 15
fi


# unpack the tar-ball
if ${unpack_source_p}
then
    # Was it previously unpacked?
    if ${delete_source_p} || test ! -d ${tmpdir}/${module}*
    then
	/bin/rm -rf "${tmpdir}"
	/bin/mkdir ${tmpdir}
	if [ ! -d ${tmpdir} ]
	then
	    echo "Problem creating work directory"
	    exit 1
	fi
	cd ${tmpdir} || exit 1
	echo `date`: Unpacking tar-ball ...
	case ${snapshot} in
	    *.tar.bz2 ) bzcat ${snapshot} ;;
	    *.tar ) cat ${snapshot} ;;
	    * ) ECHO Bad file ${snapshot} ; exit 1 ;;
	esac | tar xf -
    fi
fi
module=`basename ${snapshot}`
module=`basename ${module} .bz2`
module=`basename ${module} .tar`
srcdir=`echo ${tmpdir}/${module}*`
version_in=${srcdir}/gdb/version.in
if [ ! -r ${version_in} ]
then
    echo ERROR: missing version file 1>&2
    exit 1
fi
version=`cat ${version_in}`


# THIS HAS SUFFERED BIT ROT
if ${check_warning_p} && test -d "${srcdir}"
then
    echo `date`: Parsing compiler warnings 1>&2
    cat ${root}/ari.compile | $AWK '
BEGIN {
    FS=":";
}
/^[^:]*:[0-9]*: warning:/ {
  file = $1;
  #sub (/^.*\//, "", file);
  warning[file] += 1;
}
/^[^:]*:[0-9]*: error:/ {
  file = $1;
  #sub (/^.*\//, "", file);
  error[file] += 1;
}
END {
  for (file in warning) {
    print file ":warning:" level[file]
  }
  for (file in error) {
    print file ":error:" level[file]
  }
}
' > ${root}/ari.warning.bug
fi

# THIS HAS SUFFERED BIT ROT
if ${check_indent_p} && test -d "${srcdir}"
then
    printf "Analizing file indentation:" 1>&2
    ( cd "${srcdir}" && /bin/sh $HOME/ss/gdb_find.sh ${project} | while read f
    do
	if /bin/sh $HOME/ss/gdb_indent.sh < ${f} 2>/dev/null | cmp -s - ${f}
	then
	    :
	else
	    # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
	    echo "${f}:0: info: indent: Indentation does not match GNU indent output"
	fi
    done ) > ${wwwdir}/ari.indent.bug
    echo ""
fi

if ${check_source_p} && test -d "${srcdir}"
then
    bugf=${wwwdir}/ari.source.bug
    oldf=${wwwdir}/ari.source.old
    srcf=${wwwdir}/ari.source.lines
    oldsrcf=${wwwdir}/ari.source.lines-old
 
    diff=${wwwdir}/ari.source.diff
    diffin=${diff}-in
    newf1=${bugf}1
    oldf1=${oldf}1
    oldpruned=${oldf1}-pruned
    newpruned=${newf1}-pruned

    cp -f ${bugf} ${oldf}
    cp -f ${srcf} ${oldsrcf}
    rm -f ${srcf}
    echo "`date`: Using source lines ${srcf}" 1>&2
    echo "`date`: Checking source code" 1>&2
    ( cd "${srcdir}" && /bin/sh $HOME/ss/gdb_find.sh "${project}" | \
	xargs /bin/sh $HOME/ss/gdb_ari.sh -Werror -Wall --print-idx --src=${srcf} 
    ) > ${bugf}
    # Remove things we are not interested in to signal by email
    # gdbarch changes are not important here
    sed -e "/.*: gdbarch:.*/d" ${oldf} > ${oldf1}
    sed -e "/.*: gdbarch:.*/d" ${bugf} > ${newf1}
    # Remove line number info so that code inclusion/deletion
    # has no impact on the result
    sed -e "s/\([^:]*\):\([^:]*\):\(.*\)/\1:0:\3/" ${oldf1} > ${oldpruned}
    sed -e "s/\([^:]*\):\([^:]*\):\(.*\)/\1:0:\3/" ${newf1} > ${newpruned}
    # Use diff without option to get normal diff output that
    # is reparsed after
    diff ${oldpruned} ${newpruned} > ${diffin}
    # Only keep new warnings
    sed -n -e "/^>.*/p" ${diffin} > ${diff}
    sedscript=${wwwdir}/sedscript
    script=${wwwdir}/script
    sed -n -e "s|\(^[0-9,]*\)a\(.*\)|echo \1a\2 \n \
	sed -n \'\2s:\\\\(.*\\\\):> \\\\1:p\' ${newf1}|p" \
	-e "s|\(^[0-9,]*\)d\(.*\)|echo \1d\2\n \
	sed -n \'\1s:\\\\(.*\\\\):< \\\\1:p\' ${oldf1}|p" \
	-e "s|\(^[0-9,]*\)c\(.*\)|echo \1c\2\n \
	sed -n \'\1s:\\\\(.*\\\\):< \\\\1:p\' ${oldf1} \n \
	sed -n \"\2s:\\\\(.*\\\\):> \\\\1:p\" ${newf1}|p" \
	${diffin} > ${sedscript}
    ${SHELL} ${sedscript} > ${wwwdir}/message
    sed -n \
	-e "s;\(.*\);echo \\\"\1\\\";p" \
	-e "s;.*< \([^:]*\):\([0-9]*\):.*;grep \"^\1:\2:\" ${oldsrcf};p" \
	-e "s;.*> \([^:]*\):\([0-9]*\):.*;grep \"^\1:\2:\" ${srcf};p" \
	${wwwdir}/message > ${script}
    ${SHELL} ${script} > ${wwwdir}/mail-message
    # Check if ${diff} is not empty
    if [ -s ${diff} ]; then
	# Send an email to muller@sourceware.org	
	mutt -s "New ARI warning `date`" -i ${wwwdir}/mail-message \
	    muller@sourceware.org
    else
      if [ -s ${mail-message} ]; then
	# Send an email to muller@sourceware.org	
	mutt -s "ARI warning list change `date`" -i ${wwwdir}/mail-message \
	    muller@sourceware.org
      fi
    fi
fi




if ${check_doschk_p} && test -d "${srcdir}"
then
    echo "`date`: Checking for doschk" 1>&2
    rm -f "${wwwdir}"/ari.doschk.*
    fnchange_lst="${srcdir}"/gdb/config/djgpp/fnchange.lst
    fnchange_awk="${wwwdir}"/ari.doschk.awk
    doschk_in="${wwwdir}"/ari.doschk.in
    doschk_out="${wwwdir}"/ari.doschk.out
    doschk_bug="${wwwdir}"/ari.doschk.bug
    doschk_char="${wwwdir}"/ari.doschk.char

    # Transform fnchange.lst into fnchange.awk.  The program DJTAR
    # does a textual substitution of each file name using the list.
    # Generate an awk script that does the equivalent - matches an
    # exact line and then outputs the replacement.

    sed -e 's;@[^@]*@[/]*\([^ ]*\) @[^@]*@[/]*\([^ ]*\);\$0 == "\1" { print "\2"\; next\; };' \
	< "${fnchange_lst}" > "${fnchange_awk}"
    echo '{ print }' >> "${fnchange_awk}"

    # Do the raw analysis - transform the list of files into the DJGPP
    # equivalents putting it in the .in file
    ( cd "${srcdir}" && find * \
	-name '*.info-[0-9]*' -prune \
	-o -name tcl -prune \
	-o -name itcl -prune \
	-o -name tk -prune \
	-o -name libgui -prune \
	-o -name tix -prune \
	-o -name dejagnu -prune \
	-o -name expect -prune \
	-o -type f -print ) \
    | $AWK -f ${fnchange_awk} > ${doschk_in}

    # Start with a clean slate
    rm -f ${doschk_bug}

    # Check for any invalid characters.
    grep '[\+\,\;\=\[\]\|\<\>\\\"\:\?\*]' < ${doschk_in} > ${doschk_char}
    # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
    sed < ${doschk_char} >> ${doschk_bug} \
	-e s'/$/:0: dos: DOSCHK: Invalid DOS character/'

    # Magic to map ari.doschk.out to ari.doschk.bug goes here
    doschk < ${doschk_in} > ${doschk_out}
    cat ${doschk_out} | $AWK >> ${doschk_bug} '
BEGIN {
    state = 1;
    invalid_dos = state++; bug[invalid_dos] = "invalid DOS file name";  category[invalid_dos] = "dos";
    same_dos = state++;    bug[same_dos]    = "DOS 8.3";                category[same_dos] = "dos";
    same_sysv = state++;   bug[same_sysv]   = "SysV";
    long_sysv = state++;   bug[long_sysv]   = "long SysV";
    internal = state++;    bug[internal]    = "internal doschk";        category[internal] = "internal";
    state = 0;
}
/^$/ { state = 0; next; }
/^The .* not valid DOS/     { state = invalid_dos; next; }
/^The .* same DOS/          { state = same_dos; next; }
/^The .* same SysV/         { state = same_sysv; next; }
/^The .* too long for SysV/ { state = long_sysv; next; }
/^The .* /                  { state = internal; next; }

NF == 0 { next }

NF == 3 { name = $1 ; file = $3 }
NF == 1 { file = $1 }
NF > 3 && $2 == "-" { file = $1 ; name = gensub(/^.* - /, "", 1) }

state == same_dos {
    # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
    print  file ":0: " category[state] ": " \
	name " " bug[state] " " " dup: " \
	" DOSCHK - the names " name " and " file " resolve to the same" \
	" file on a " bug[state] \
	" system.<br>For DOS, this can be fixed by modifying the file" \
	" fnchange.lst."
    next
}
state == invalid_dos {
    # ari.*.bug: <FILE>:<LINE>: <SEVERITY>: <CATEGORY>: <DOC>
    print file ":0: " category[state] ": "  name ": DOSCHK - " name
    next
}
state == internal {
    # ari.*.bug: <FILE>:<LINE>: <SEVERITY>: <CATEGORY>: <DOC>
    print file ":0: " category[state] ": "  bug[state] ": DOSCHK - a " \
	bug[state] " problem"
}
'
fi



if ${check_werror_p} && test -d "${srcdir}"
then
    echo "`date`: Checking Makefile.in for non- -Werror rules"
    rm -f ${wwwdir}/ari.werror.*
    cat "${srcdir}/${project}/Makefile.in" | $AWK > ${wwwdir}/ari.werror.bug '
BEGIN {
    count = 0
    cont_p = 0
    full_line = ""
}
/^[-_[:alnum:]]+\.o:/ {
    file = gensub(/.o:.*/, "", 1) ".c"
}

/[^\\]\\$/ { gsub (/\\$/, ""); full_line = full_line $0; cont_p = 1; next; }
cont_p { $0 = full_line $0; cont_p = 0; full_line = ""; }

/\$\(COMPILE\.pre\)/ {
    print file " has  line " $0
    if (($0 !~ /\$\(.*ERROR_CFLAGS\)/) && ($0 !~ /\$\(INTERNAL_CFLAGS\)/)) {
	# ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
	print "'"${project}"'/" file ":0: info: Werror: The file is not being compiled with -Werror"
    }
}
'
fi


# From the warnings, generate the doc and indexed bug files
if ${update_doc_p}
then
    cd ${wwwdir}
    rm -f ari.doc ari.idx ari.doc.bug
    # Generate an extra file containing all the bugs that the ARI can detect.
    /bin/sh $HOME/ss/gdb_ari.sh -Werror -Wall --print-idx --print-doc >> ari.doc.bug
    cat ari.*.bug | $AWK > ari.idx '
BEGIN {
    FS=": *"
}
{
    # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
    file = $1
    line = $2
    category = $3
    bug = $4
    if (! (bug in cat)) {
	cat[bug] = category
	# strip any trailing .... (supplement)
	doc[bug] = gensub(/ \([^\)]*\)$/, "", 1, $5)
	count[bug] = 0
    }
    if (file != "") {
	count[bug] += 1
	# ari.*.idx: <BUG>:<FILE>:<CATEGORY>
	print bug ":" file ":" category
    }
    # Also accumulate some categories as obsolete
    if (category == "deprecated") {
	# ari.*.idx: <BUG>:<FILE>:<CATEGORY>
	if (file != "") {
	    print category ":" file ":" "obsolete"
	}
	#count[category]++
	#doc[category] = "Contains " category " code"
    }
}
END {
    i = 0;
    for (bug in count) {
	# ari.*.doc: <BUG>:<COUNT>:<CATEGORY>:<DOC>
	print bug ":" count[bug] ":" cat[bug] ":" doc[bug] >> "ari.doc"
    }
}
'
fi


# print_toc BIAS MIN_COUNT CATEGORIES TITLE

# Print a table of contents containing the bugs CATEGORIES.  If the
# BUG count >= MIN_COUNT print it in the table-of-contents.  If
# MIN_COUNT is non -ve, also include a link to the table.Adjust the
# printed BUG count by BIAS.

all=

print_toc ()
{
    bias="$1" ; shift
    min_count="$1" ; shift

    all=" $all $1 "
    categories=""
    for c in $1; do
	categories="${categories} categories[\"${c}\"] = 1 ;"
    done
    shift

    title="$@" ; shift

    echo "<p>" >> ${newari}
    echo "<a name=${title}>" | tr '[A-Z]' '[a-z]' >> ${newari}
    echo "<h3>${title}</h3>" >> ${newari}
    cat >> ${newari} # description

    cat >> ${newari} <<EOF
<p>
<table>
<tr><th align=left>BUG</th><th>Total</th><th align=left>Description</th></tr>
EOF
    # ari.*.doc: <BUG>:<COUNT>:<CATEGORY>:<DOC>
    cat ${wwwdir}/ari.doc \
    | sort -t: +1rn -2 +0d \
    | $AWK >> ${newari} '
BEGIN {
    FS=":"
    '"$categories"'
    MIN_COUNT = '${min_count}'
    BIAS = '${bias}'
    total = 0
    nr = 0
}
{
    # ari.*.doc: <BUG>:<COUNT>:<CATEGORY>:<DOC>
    bug = $1
    count = $2
    category = $3
    doc = $4
    if (count < MIN_COUNT) next
    if (!(category in categories)) next
    nr += 1
    total += count
    printf "<tr>"
    printf "<th align=left valign=top><a name=\"%s\">", bug
    printf "%s", gensub(/_/, " ", "g", bug)
    printf "</a></th>"
    printf "<td align=right valign=top>"
    if (count > 0 && MIN_COUNT >= 0) {
	printf "<a href=\"#,%s\">%d</a></td>", bug, count + BIAS
    } else {
	printf "%d", count + BIAS
    }
    printf "</td>"
    printf "<td align=left valign=top>%s</td>", doc
    printf "</tr>"
    print ""
}
END {
    print "<tr><th align=right valign=top>" nr "</th><th align=right valign=top>" total "</th><td></td></tr>"
}
'
cat >> ${newari} <<EOF
</table>
<p>
EOF
}


print_table ()
{
    categories=""
    for c in $1; do
	categories="${categories} categories[\"${c}\"] = 1 ;"
    done
    # Remember to prune the dir prefix from projects files
    # ari.*.idx: <BUG>:<FILE>:<CATEGORY>
    cat ${wwwdir}/ari.idx | $AWK >> ${newari} '
function qsort (table,
		middle, tmp, left, nr_left, right, nr_right, result) {
    middle = ""
    for (middle in table) { break; }
    nr_left = 0;
    nr_right = 0;
    for (tmp in table) {
	if (tolower(tmp) < tolower(middle)) {
	    nr_left++
	    left[tmp] = tmp
	} else if (tolower(tmp) > tolower(middle)) {
	    nr_right++
	    right[tmp] = tmp
	}
    }
    #print "qsort " nr_left " " middle " " nr_right > "/dev/stderr"
    result = ""
    if (nr_left > 0) {
	result = qsort(left) SUBSEP
    }
    result = result middle
    if (nr_right > 0) {
	result = result SUBSEP qsort(right)
    }
    return result
}
function print_heading (where, bug_i) {
    print ""
    print "<tr border=1>"
    print "<th align=left>File</th>"
    print "<th align=left><em>Total</em></th>"
    print "<th></th>"
    for (bug_i = 1; bug_i <= nr_bug; bug_i++) {
	bug = i2bug[bug_i];
	printf "<th>"
	# The title names are offset by one.  Otherwize, when the browser
	# jumps to the name it leaves out half the relevant column.
	#printf "<a name=\",%s\">&nbsp;</a>", bug
	printf "<a name=\",%s\">&nbsp;</a>", i2bug[bug_i-1]
	printf "<a href=\"#%s\">", bug
	printf "%s", gensub(/_/, " ", "g", bug)
	printf "</a>\n"
	printf "</th>\n"
    }
    #print "<th></th>"
    printf "<th><a name=\"%s,\">&nbsp;</a></th>\n", i2bug[bug_i-1]
    print "<th align=left><em>Total</em></th>"
    print "<th align=left>File</th>"
    print "</tr>"
}
function print_totals (where, bug_i) {
    print "<th align=left><em>Totals</em></th>"
    printf "<th align=right>"
    printf "<em>%s</em>", total
    printf "&gt;"
    printf "</th>\n"
    print "<th></th>";
    for (bug_i = 1; bug_i <= nr_bug; bug_i++) {
	bug = i2bug[bug_i];
	printf "<th align=right>"
	printf "<em>"
	printf "<a href=\"#%s\">%d</a>", bug, bug_total[bug]
	printf "</em>";
	printf "<a href=\"#%s,%s\">^</a>", prev_file[bug, where], bug
	printf "<a href=\"#%s,%s\">v</a>", next_file[bug, where], bug
	printf "<a name=\"%s,%s\">&nbsp;</a>", where, bug
	printf "</th>";
	print ""
    }
    print "<th></th>"
    printf "<th align=right>"
    printf "<em>%s</em>", total
    printf "&lt;"
    printf "</th>\n"
    print "<th align=left><em>Totals</em></th>"
    print "</tr>"
}
BEGIN {
    FS = ":"
    '"${categories}"'
    nr_file = 0;
    nr_bug = 0;
}
{
    # ari.*.idx: <BUG>:<FILE>:<CATEGORY>
    bug = $1
    file = $2
    category = $3
    # Interested in this
    if (!(category in categories)) next
    # Totals
    db[bug, file] += 1
    bug_total[bug] += 1
    file_total[file] += 1
    total += 1
}
END {

    # Sort the files and bugs creating indexed lists.
    nr_bug = split(qsort(bug_total), i2bug, SUBSEP);
    nr_file = split(qsort(file_total), i2file, SUBSEP);

    # Dummy entries for first/last
    i2file[0] = 0
    i2file[-1] = -1
    i2bug[0] = 0
    i2bug[-1] = -1

    # Construct a cycle of next/prev links.  The file/bug "0" and "-1"
    # are used to identify the start/end of the cycle.  Consequently,
    # prev(0) = -1 (prev of start is the end) and next(-1) = 0 (next
    # of end is the start).

    # For all the bugs, create a cycle that goes to the prev / next file.
    for (bug_i = 1; bug_i <= nr_bug; bug_i++) {
	bug = i2bug[bug_i]
	prev = 0
	prev_file[bug, 0] = -1
	next_file[bug, -1] = 0
	for (file_i = 1; file_i <= nr_file; file_i++) {
	    file = i2file[file_i]
	    if ((bug, file) in db) {
		prev_file[bug, file] = prev
		next_file[bug, prev] = file
		prev = file
	    }
	}
	prev_file[bug, -1] = prev
	next_file[bug, prev] = -1
    }

    # For all the files, create a cycle that goes to the prev / next bug.
    for (file_i = 1; file_i <= nr_file; file_i++) {
	file = i2file[file_i]
	prev = 0
	prev_bug[file, 0] = -1
	next_bug[file, -1] = 0
	for (bug_i = 1; bug_i <= nr_bug; bug_i++) {
	    bug = i2bug[bug_i]
	    if ((bug, file) in db) {
		prev_bug[file, bug] = prev
		next_bug[file, prev] = bug
		prev = bug
	    }
	}
	prev_bug[file, -1] = prev
	next_bug[file, prev] = -1
    }

    print "<table border=1 cellspacing=0>"
    print "<tr></tr>"
    print_heading(0);
    print "<tr></tr>"
    print_totals(0);
    print "<tr></tr>"

    for (file_i = 1; file_i <= nr_file; file_i++) {
	file = i2file[file_i];
	pfile = gensub(/^'${project}'\//, "", 1, file)
	print ""
	print "<tr>"
	print "<th align=left><a name=\"" file ",\">" pfile "</a></th>"
	printf "<th align=right>"
	printf "%s", file_total[file]
	printf "<a href=\"#%s,%s\">&gt;</a>", file, next_bug[file, 0]
	printf "</th>\n"
	print "<th></th>"
	for (bug_i = 1; bug_i <= nr_bug; bug_i++) {
	    bug = i2bug[bug_i];
	    if ((bug, file) in db) {
		printf "<td align=right>"
		printf "<a href=\"#%s\">%d</a>", bug, db[bug, file]
		printf "<a href=\"#%s,%s\">^</a>", prev_file[bug, file], bug
		printf "<a href=\"#%s,%s\">v</a>", next_file[bug, file], bug
		printf "<a name=\"%s,%s\">&nbsp;</a>", file, bug
		printf "</td>"
		print ""
	    } else {
		print "<td>&nbsp;</td>"
		#print "<td></td>"
	    }
	}
	print "<th></th>"
	printf "<th align=right>"
	printf "%s", file_total[file]
	printf "<a href=\"#%s,%s\">&lt;</a>", file, prev_bug[file, -1]
	printf "</th>\n"
	print "<th align=left>" pfile "</th>"
	print "</tr>"
    }

    print "<tr></tr>"
    print_totals(-1)
    print "<tr></tr>"
    print_heading(-1);
    print "<tr></tr>"
    print ""
    print "</table>"
    print ""
}
'
}


# Make the scripts available
cp $HOME/ss/gdb_*.sh ${wwwdir}

# Compute the ARI index - ratio of zero vs non-zero problems.
indexes=`awk '
BEGIN {
    FS=":"
}
{
    # ari.*.doc: <BUG>:<COUNT>:<CATEGORY>:<DOC>
    bug = $1; count = $2; category = $3; doc = $4

    if (bug ~ /^legacy_/) legacy++
    if (bug ~ /^deprecated_/) deprecated++

    if (category !~ /^gdbarch$/) {
	bugs += count
    }
    if (count == 0) {
	oks++
    }
}
END {
    #print "tests/ok:", nr / ok
    #print "bugs/tests:", bugs / nr
    #print "bugs/ok:", bugs / ok
    print bugs / ( oks + legacy + deprecated )
}
' ${wwwdir}/ari.doc`

# Merge, generating the ARI tables.
if ${update_web_p}
then
    echo "Create the ARI table" 1>&2
    oldari=${wwwdir}/old.html
    ari=${wwwdir}/index.html
    newari=${wwwdir}/new.html
    rm -f ${newari} ${newari}.gz
    cat <<EOF >> ${newari}
<html>
<head>
<title>A.R. Index for GDB version ${version}</title>
</head>
<body>

<center><h2>A.R. Index for GDB version ${version}<h2></center>

<!-- body, update above using ../index.sh -->

<!-- Navigation.  This page contains the following anchors.
"BUG": The definition of the bug.
"FILE,BUG": The row/column containing FILEs BUG count
"0,BUG", "-1,BUG": The top/bottom total for BUGs column.
"FILE,O", "FILE,-1": The left/right total for FILEs row.
",BUG": The top title for BUGs column.
"FILE,": The left title for FILEs row.
-->

<center><h3>${indexes}</h3></center>
<center><h3>You can not take this seriously!</h3></center>

<center>
Also available:
<a href="../gdb/ari/">most recent branch</a>
|
<a href="../gdb/current/ari/">current</a>
|
<a href="../gdb/download/ari/">last release</a>
</center>

<center>
Last updated: `date -u`
</center>
EOF

    print_toc 0 1 "internal regression" Critical <<EOF
Things previously eliminated but returned.  This should always be empty.
EOF

    print_table "regression code comment obsolete"

    print_toc 0 0 code Code <<EOF
Coding standard problems, portability problems, readability problems.
EOF

    print_toc 0 0 comment Comments <<EOF
Problems concerning comments in source files.
EOF

    print_toc 0 -1 dos DOS 8.3 File Names <<EOF
File names with problems on 8.3 file systems.
EOF

    print_toc -2 -1 deprecated Deprecated <<EOF
Mechanisms that have been replaced with something better, simpler,
cleaner; or are no longer required by core-GDB.  New code should not
use deprecated mechanisms.  Existing code, when touched, should be
updated to use non-deprecated mechanisms.  See obsolete and deprecate.
(The declaration and definition are hopefully excluded from count so
zero should indicate no remaining uses).
EOF

    print_toc 0 0 obsolete Obsolete <<EOF
Mechanisms that have been replaced, but have not yet been marked as
such (using the deprecated_ prefix).  See deprecate and deprecated.
EOF

    print_toc 0 -1 deprecate Deprecate <<EOF
Mechanisms that are a candidate for being made obsolete.  Once core
GDB no longer depends on these mechanisms and/or there is a
replacement available, these mechanims can be deprecated (adding the
deprecated prefix) obsoleted (put into category obsolete) or deleted.
See obsolete and deprecated.
EOF

    print_toc -2 -1 legacy Legacy <<EOF
Methods used to prop up targets using targets that still depend on
deprecated mechanisms. (The method's declaration and definition are
hopefully excluded from count).
EOF

    print_toc -2 -1 gdbarch Gdbarch <<EOF
Count of calls to the gdbarch set methods.  (Declaration and
definition hopefully excluded from count).
EOF

    print_toc 0 -1 macro Macro <<EOF
Breakdown of macro definitions (and #undef) in configuration files.
EOF

    print_toc 0 0 regression Fixed <<EOF
Problems that have been expunged from the source code.
EOF

    # Check for invalid categories
    for a in $all; do
	alls="$alls all[$a] = 1 ;"
    done
    cat ari.*.doc | $AWK >> ${newari} '
BEGIN {
    FS = ":"
    '"$alls"'
}
{
    # ari.*.doc: <BUG>:<COUNT>:<CATEGORY>:<DOC>
    bug = $1
    count = $2
    category = $3
    doc = $4
    if (!(category in all)) {
	print "<b>" category "</b>: no documentation<br>"
    }
}
'

    cat >> ${newari} <<EOF
<center>
Input files:
`( cd ${wwwdir} && ls ari.*.bug ari.idx ari.doc ) | while read f
do
    echo "<a href=\"${f}\">${f}</a>"
done`
</center>

<center>
Scripts:
`( cd ${wwwdir} && ls *.sh ) | while read f
do
    echo "<a href=\"${f}\">${f}</a>"
done`
</center>

<!-- /body, update below using ../index.sh -->
</body>
</html>
EOF

    for i in . .. ../..; do
	x=${wwwdir}/${i}/index.sh
	if test -x $x; then
	    $x ${newari}
	    break
	fi
    done

    gzip -c -v -9 ${newari} > ${newari}.gz
    
    cp ${ari} ${oldari}
    cp ${ari}.gz ${oldari}.gz
    cp ${newari} ${ari}
    cp ${newari}.gz ${ari}.gz

fi # update_web_p

# ls -l ${wwwdir}

exit 0

Re: [commit] Fix fnchange.lst

[Eli Zaretskii]

> Date: Sun, 20 Sep 2009 09:10:48 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
>     http://www.sourceware.org/gdb/ari/
> 
> I see there are 10 warnings remaining. Are these actually fixable?

Not easily: they belong to libdecnumber and gnulib, which are compiled
into the DJGPP port.  To fix those, I need to add stuff to
gdb/config/djgpp to actually edit some source files, not just rename
files during unpacking (which is what fnchange.lst does).

It's on my TODO, but when I will get to it is anybody's guess.  Not
that too many people on the DJGPP forum are crying bloody murder for
lack of support of the build on plain DOS systems...

> I don't quite understand what the warnings say, because I can't find
> files such as decimal1.h, for instance.

The original output of doschk is mangled by the ARI script, as part of
accounting for fnchange.lst renaming, so the first of the two names it
complains about is already 8+3-butchered.  Run "find . | doschk" in
the source tree, and you will see the original file names that clash
after 8+3 truncation.

> I don't think you'll have write priviledges. If you want, I can add
> your key to the authorized_keys, or I can commit the changes for you.

The latter would be more than enough.  I will see if I can find time
to craft a script that you wanted.

Thanks.

Re: [commit] Fix fnchange.lst

[Eli Zaretskii]

> Date: Sun, 20 Sep 2009 20:46:53 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: gdb-patches@sourceware.org
> 
> > I don't think you'll have write priviledges. If you want, I can add
> > your key to the authorized_keys, or I can commit the changes for you.
> 
> The latter would be more than enough.  I will see if I can find time
> to craft a script that you wanted.

Here you go.  Save as "chkfnames" and invoke it like this:

    srcdir=FOO tmpdir=BAR ./chkfnames

It will produce the list of problematic files on stdout, together with
the reasons for their inclusion.  tmpdir is used to create an Awk
script that filters out files already renamed by fnchange.lst; you can
remove that script when you are done.

Enjoy.


--------------------------------------
#!/bin/sh

fnchange_lst="${srcdir}"/gdb/config/djgpp/fnchange.lst
fnchange_awk="${tmpdir}"/fnchange.awk

# Transform fnchange.lst into fnchange.awk.  The program DJTAR
# does a textual substitution of each file name using the list.
# Generate an awk script that does the equivalent - matches an
# exact line and then outputs the replacement.

sed -e 's;@[^@]*@[/]*\([^ ]*\) @[^@]*@[/]*\([^ ]*\);\$0 == "\1" { print "\2"\; next\; };' \
    < "${fnchange_lst}" > "${fnchange_awk}"
echo '{ print }' >> "${fnchange_awk}"

( cd "${srcdir}" && find * \
    -name '*.info-[0-9]*' -prune \
    -o -name tcl -prune \
    -o -name itcl -prune \
    -o -name tk -prune \
    -o -name libgui -prune \
    -o -name tix -prune \
    -o -name dejagnu -prune \
    -o -name expect -prune \
    -o -type f -print ) \
| awk -f ${fnchange_awk} | doschk | sed '/The following file names are too long for SysV:/q' | fgrep -v 'The following file names are too long for SysV:'

exit 0

Re: [commit] Fix fnchange.lst

[Joel Brobecker]

> Here you go.  Save as "chkfnames" and invoke it like this:
> 
>     srcdir=FOO tmpdir=BAR ./chkfnames

Thanks. I propose we check this script somewhere in GDB and change
the interface to something like:

    % chkfnames SRCDIR [TMPDIR]

(TMPDIR would be defaulted to /tmp if not provided)

I'll then add to this script to the release procedure.

-- 
Joel

Re: [commit] Fix fnchange.lst

[Joel Brobecker]

> Here you go.  Save as "chkfnames" and invoke it like this:
> 
>     srcdir=FOO tmpdir=BAR ./chkfnames

Can we make the script ignore libdecnumber and gnulib, .cvsignore
files?  Should we also skip testsuite files?

Right now, the script as is generates a lot of output about some things
that we cannot fix in GDB itself. From a Q/A perspective, this is going
to cause us to miss.

What should we do with the entries in section called:
"The following resolve to the same SysV file names:"

?
-- 
Joel

Re: [commit] Fix fnchange.lst

[Eli Zaretskii]

> Date: Thu, 1 Oct 2009 10:01:07 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > Here you go.  Save as "chkfnames" and invoke it like this:
> > 
> >     srcdir=FOO tmpdir=BAR ./chkfnames
> 
> Can we make the script ignore libdecnumber and gnulib, .cvsignore
> files?

There are only a few of files in libdecnumber and gnulib, so I didn't
think it was justified to remove them.  They do present a real
problem.

As for .cvsignore, they shouldn't present a problem because they are
not in the tarball.  If you are running the script on the CVS sandbox,
then I guess we need to ignore them.  I will see what I can do.

> Should we also skip testsuite files?

I don't think so.  Any conflicts cause trouble when unpacking the
tarball on 8+3 and some older Windows systems.

> Right now, the script as is generates a lot of output about some things
> that we cannot fix in GDB itself. From a Q/A perspective, this is going
> to cause us to miss.

I agree that too much noise is bad, but do we really have a lot of
noise?  How many positives are you willing to have before they are
noise?

> What should we do with the entries in section called:
> "The following resolve to the same SysV file names:"

Nothing.  We don't care about this part of doschk's output.  I thought
I made that section disappear, but it sounds like I goofed.

Re: [commit] Fix fnchange.lst

[Joel Brobecker]

> There are only a few of files in libdecnumber and gnulib, so I didn't
> think it was justified to remove them.  They do present a real
> problem.

I know, but I am trying to qualify a release, and from my perspective,
this is a known issue that is not blocking the release. So they are
a visual distraction.

> As for .cvsignore, they shouldn't present a problem because they are
> not in the tarball.  If you are running the script on the CVS sandbox,
> then I guess we need to ignore them.  I will see what I can do.

Thanks. The reason why I'm running the script on a CVS sandbox, is that
I am trying to verify that things have not regressed in that department
before making the tarballs.

> > Should we also skip testsuite files?
> 
> I don't think so.  Any conflicts cause trouble when unpacking the
> tarball on 8+3 and some older Windows systems.

Hmmm, we may have some work to do. I remember seeing some entries
for the testsuite, except I can't remember whether they were in a
section that we care about or not.

> I agree that too much noise is bad, but do we really have a lot of
> noise?  How many positives are you willing to have before they are
> noise?
> 
> > What should we do with the entries in section called:
> > "The following resolve to the same SysV file names:"
> 
> Nothing.  We don't care about this part of doschk's output.  I thought
> I made that section disappear, but it sounds like I goofed.

At the time when I ran the program, I had several pages of output
(in a 65-line terminal). It will be better once we eliminate the
SysV errors from the list. But what I'm trying to do is to automate
the task of validating the source file names for DJGPP.  I suppose
I could parse the output and eliminate the known issues, but if
you can do this exclusion from the script itself (say using a switch
to control that), then it simplifies the release process. And it helps
avoiding a silly bug in my release scripts from missing something.

-- 
Joel