Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add autoload-breakpoints [6/6] autoload-breakpoints doc
Date: Sat, 28 Apr 2012 08:33:00 -0000	[thread overview]
Message-ID: <83mx5w6z5z.fsf@gnu.org> (raw)
In-Reply-To: <4F9B9915.60101@mentor.com>

> Date: Sat, 28 Apr 2012 15:15:33 +0800
> From: Hui Zhu <hui_zhu@mentor.com>
> CC: <gdb-patches@sourceware.org>
> 
> >>> This part is not very clear. What about following part?
> >>>
> >>> When @value{GDBN} get this packet, it will delete this breakpoint
> >>> as it have been removed in the target. So when the target send
> >>> this packet, it needs to remove these breakpoints in local part by itself.
> >>
> >> Who is sending this packet, the target or GDB? I understand that the
> >> target sends it, because you say "when GDB gets this packet".
> >>
> > Yes, the target send it.
> >
> >> But if the target sends this packet, then it should be quite clear
> >> that it (the target) should delete the breakpoint.
> >
> > In prev version, GDB will send delete cmd to target when it got a autoload-breakpoint R to delete them. But I thought it will be hard to handle in both for target and GDB.
> > So I change it: GDB will not send delete cmd after get the autoload-breakpoints R packet, the target will remove them by itself.
> >
> > In fact, I would
> >> expect the packet to be a side effect of deletion on the target side.
> >> Is the above correct?
> >
> > Yes.
> >
> > Thanks,
> > Hui
> 
> Ping.

Please send me a fixed patch to review, I don't think you sent one
after our last exchange.

Thanks.


      reply	other threads:[~2012-04-28  8:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 10:55 Hui Zhu
2012-04-18 12:16 ` Hui Zhu
2012-04-18 18:56   ` Eli Zaretskii
2012-04-19 12:51     ` Hui Zhu
2012-04-19 15:34       ` Eli Zaretskii
2012-04-20  0:06         ` Hui Zhu
2012-04-28  8:25           ` Hui Zhu
2012-04-28  8:33             ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mx5w6z5z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox