From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7941 invoked by alias); 28 Apr 2012 08:25:45 -0000 Received: (qmail 7926 invoked by uid 22791); 28 Apr 2012 08:25:42 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Apr 2012 08:25:23 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M3600I00JLPJZ00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 28 Apr 2012 11:25:22 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.21.156]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M3600I1MKQ9J5A0@a-mtaout21.012.net.il>; Sat, 28 Apr 2012 11:25:22 +0300 (IDT) Date: Sat, 28 Apr 2012 08:33:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v2] Add autoload-breakpoints [6/6] autoload-breakpoints doc In-reply-to: <4F9B9915.60101@mentor.com> To: Hui Zhu Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83mx5w6z5z.fsf@gnu.org> References: <4F8562EE.6080306@mentor.com> <4F8E9D3A.5000809@mentor.com> <834nsgkh28.fsf@gnu.org> <4F9005A3.2010008@mentor.com> <83wr5bivyz.fsf@gnu.org> <4F90A281.4040205@mentor.com> <4F9B9915.60101@mentor.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg01051.txt.bz2 > Date: Sat, 28 Apr 2012 15:15:33 +0800 > From: Hui Zhu > CC: > > >>> This part is not very clear. What about following part? > >>> > >>> When @value{GDBN} get this packet, it will delete this breakpoint > >>> as it have been removed in the target. So when the target send > >>> this packet, it needs to remove these breakpoints in local part by itself. > >> > >> Who is sending this packet, the target or GDB? I understand that the > >> target sends it, because you say "when GDB gets this packet". > >> > > Yes, the target send it. > > > >> But if the target sends this packet, then it should be quite clear > >> that it (the target) should delete the breakpoint. > > > > In prev version, GDB will send delete cmd to target when it got a autoload-breakpoint R to delete them. But I thought it will be hard to handle in both for target and GDB. > > So I change it: GDB will not send delete cmd after get the autoload-breakpoints R packet, the target will remove them by itself. > > > > In fact, I would > >> expect the packet to be a side effect of deletion on the target side. > >> Is the above correct? > > > > Yes. > > > > Thanks, > > Hui > > Ping. Please send me a fixed patch to review, I don't think you sent one after our last exchange. Thanks.