Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <hui_zhu@mentor.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Add autoload-breakpoints [6/6] autoload-breakpoints doc
Date: Fri, 20 Apr 2012 00:06:00 -0000	[thread overview]
Message-ID: <4F90A281.4040205@mentor.com> (raw)
In-Reply-To: <83wr5bivyz.fsf@gnu.org>

On 04/19/12 23:26, Eli Zaretskii wrote:
>> Date: Thu, 19 Apr 2012 20:31:31 +0800
>> From: Hui Zhu<hui_zhu@mentor.com>
>> CC:<gdb-patches@sourceware.org>
>>
>>>> +@item @var{id}@samp{:}@samp{R}
>>>> +This is the remove packet.
>>>> +@var{id} is the number of the autoload-breakpoint that this command
>>>> +wants to remove, encoded as a hex string.
>>>> +@value{GDBN} will remove this breakpoint as it have been removed in
>>>> +the target.
>>>
>>> I don't understand the last sentence.  Please explain.
>>>
>>>>                So when the target remove the breakpoint, it need remove
>>>> +this breakpoint with itself.   ^^^^^^                    ^^^^^^^^^^^
>>>                      ^^^^^^^^^^^
>>> "removes", "needs to remove", and "by itself".
>>>
>>> By the way, what non-trivial information does this sentence convey?
>>> It seems to say "when the target removes the breakpoint, it needs to
>>> remove the breakpoint", which is trivial.  What am I missing here?
>>
>> This part is not very clear.  What about following part?
>>
>> When @value{GDBN} get this packet, it will delete this breakpoint
>> as it have been removed in the target.  So when the target send
>> this packet, it needs to remove these breakpoints in local part by itself.
>
> Who is sending this packet, the target or GDB?  I understand that the
> target sends it, because you say "when GDB gets this packet".
>
Yes, the target send it.

> But if the target sends this packet, then it should be quite clear
> that it (the target) should delete the breakpoint.

In prev version, GDB will send delete cmd to target when it got a 
autoload-breakpoint R to delete them.  But I thought it will be hard to 
handle in both for target and GDB.
So I change it: GDB will not send delete cmd after get the 
autoload-breakpoints R packet, the target will remove them by itself.

In fact, I would
> expect the packet to be a side effect of deletion on the target side.
> Is the above correct?

Yes.

Thanks,
Hui


  reply	other threads:[~2012-04-19 23:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 10:55 Hui Zhu
2012-04-18 12:16 ` Hui Zhu
2012-04-18 18:56   ` Eli Zaretskii
2012-04-19 12:51     ` Hui Zhu
2012-04-19 15:34       ` Eli Zaretskii
2012-04-20  0:06         ` Hui Zhu [this message]
2012-04-28  8:25           ` Hui Zhu
2012-04-28  8:33             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F90A281.4040205@mentor.com \
    --to=hui_zhu@mentor.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox