Re: [PATCH, doc RFA] Add "skip regexp"

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 02 Feb 2016 01:03:19 +0000
> From: Doug Evans <dje@google.com>
> 
> With this patch one can specify the skip as:
> 
> skip regexp ^std::(allocator|basic_string)<.*>::~?\1 *\(

Thanks.

> 2016-02-01  Doug Evans  <dje@google.com>
> 
> 	New command "skip regexp regular-expression".
> 	* NEWS: Document the new feature.
> 	* skip.c (skip_kind): New enum.
> 	(skiplist_entry) <filename,function_name>: Delete.
> 	<kind,text,regex,regex_valid>: New members.
> 	(skiplist_entry_kind_name): New function.
> 	(make_skip_file, make_skip_function, make_skip_regexp): New function.
> 	(free_skiplist_entry, free_skiplist_entry_cleanup): New functions.
> 	(make_free_skiplist_entry_cleanup): New function.
> 	(skip_file_command): Update.
> 	(skip_function): Update.
> 	(compile_skip_regexp, skip_regexp_command): New functions.
> 	(skip_info): Update.
> 	(sal_and_fullname): New struct.
> 	(skip_file_p, skip_function_p, skip_regexp_p): New functions.
> 	(function_name_is_marked_for_skip): Update and simplify.
> 	(_initialize_step_skip): Add "skip regexp" command.
> 
> 	doc/
> 	* gdb.texinfo (Skipping Over Functions and Files): Document
> 	"skip regexp".

The documentation parts are approved, with the following nit:

> +Functions may be skipped by providing either a function name, linespec
> +(@pxref{Specify Location}), file name, or regular expression of the
> +function's name.                          ^^^^^^^^^^^^^^^^^^^^^^^^^
   ^^^^^^^^^^^^^^^
"regular expression that matches the function's name" is more accurate
(and you also use it elsewhere in the patch).

Otherwise, fine with me, thanks.