From: Simon Marchi <simon.marchi@ericsson.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <palves@redhat.com>, <eliz@gnu.org>,
<gdb-patches@sourceware.org>
Subject: Re: [PATCH, doc RFA] Add "skip regexp"
Date: Thu, 03 Mar 2016 20:40:00 -0000 [thread overview]
Message-ID: <56D8A14F.1010801@ericsson.com> (raw)
In-Reply-To: <047d7b15faa92d0dac052d29e927@google.com>
On 16-03-03 02:21 PM, Doug Evans wrote:
> 2016-03-03 Doug Evans <dje@google.com>
>
> * gdb.base/skip.c (main): Call test_skip_file_and_function.
> * gdb.base/skip.exp: Remove hand calling test_skip_file_and_function.
>
> diff --git a/gdb/testsuite/gdb.base/skip.c b/gdb/testsuite/gdb.base/skip.c
> index b9db2a7..e43da1e 100644
> --- a/gdb/testsuite/gdb.base/skip.c
> +++ b/gdb/testsuite/gdb.base/skip.c
> @@ -25,8 +25,14 @@ void skip1_test_skip_file_and_function (void);
> int
> main ()
> {
> + int x;
> +
> /* Use comma operator to sequence evaluation of bar and foo. */
> - return baz ((bar (), foo ()));
> + x = baz ((bar (), foo ()));
> +
> + test_skip_file_and_function ();
This function should be forward-declared.
Otherwise, it LGTM. I tested it on the target that reported the problem initially,
and it's now 100% pass.
Thank you very much!
next prev parent reply other threads:[~2016-03-03 20:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 19:21 Doug Evans
2016-03-03 20:40 ` Simon Marchi [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-15 19:45 Doug Evans
2016-03-02 23:20 Doug Evans
2016-02-23 21:36 Doug Evans
2016-02-24 9:54 ` Joel Brobecker
2016-02-24 18:21 ` Doug Evans
2016-02-17 1:07 Doug Evans
2016-02-17 16:07 ` Eli Zaretskii
2016-02-29 18:55 ` Simon Marchi
2016-02-02 18:05 Doug Evans
2016-02-02 1:03 Doug Evans
2016-02-02 16:10 ` Eli Zaretskii
2016-02-04 13:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8A14F.1010801@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox