From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-130073-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25986 invoked by alias); 3 Mar 2016 20:40:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 25971 invoked by uid 89); 3 Mar 2016 20:40:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:forward, much
X-HELO: usplmg20.ericsson.net
Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 03 Mar 2016 20:40:50 +0000
Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81])	by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 66.F8.12433.FBC98D65; Thu,  3 Mar 2016 21:21:19 +0100 (CET)
Received: from [142.133.180.212] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Thu, 3 Mar 2016 15:40:48 -0500
Subject: Re: [PATCH, doc RFA] Add "skip regexp"
To: Doug Evans <dje@google.com>
References: <047d7b15faa92d0dac052d29e927@google.com>
CC: Pedro Alves <palves@redhat.com>, <eliz@gnu.org>,	<gdb-patches@sourceware.org>
From: Simon Marchi <simon.marchi@ericsson.com>
Message-ID: <56D8A14F.1010801@ericsson.com>
Date: Thu, 03 Mar 2016 20:40:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <047d7b15faa92d0dac052d29e927@google.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-03/txt/msg00059.txt.bz2

On 16-03-03 02:21 PM, Doug Evans wrote:
> 2016-03-03  Doug Evans  <dje@google.com>
> 
> 	* gdb.base/skip.c (main): Call test_skip_file_and_function.
> 	* gdb.base/skip.exp: Remove hand calling test_skip_file_and_function.
> 
> diff --git a/gdb/testsuite/gdb.base/skip.c b/gdb/testsuite/gdb.base/skip.c
> index b9db2a7..e43da1e 100644
> --- a/gdb/testsuite/gdb.base/skip.c
> +++ b/gdb/testsuite/gdb.base/skip.c
> @@ -25,8 +25,14 @@ void skip1_test_skip_file_and_function (void);
>   int
>   main ()
>   {
> +  int x;
> +
>     /* Use comma operator to sequence evaluation of bar and foo.  */
> -  return baz ((bar (), foo ()));
> +  x = baz ((bar (), foo ()));
> +
> +  test_skip_file_and_function ();

This function should be forward-declared.

Otherwise, it LGTM.  I tested it on the target that reported the problem initially,
and it's now 100% pass.

Thank you very much!