From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15457 invoked by alias); 2 Feb 2016 16:10:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15439 invoked by uid 89); 2 Feb 2016 16:10:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:TLS1.2, H*r:sk:cable.0, H*f:sk:94eb2c0, H*m:fsf X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 02 Feb 2016 16:10:10 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQdWk-0004Zb-CB for gdb-patches@sourceware.org; Tue, 02 Feb 2016 11:10:07 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQdWk-0004ZU-9J; Tue, 02 Feb 2016 11:10:02 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1988 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aQdWj-0002gl-Ha; Tue, 02 Feb 2016 11:10:01 -0500 Date: Tue, 02 Feb 2016 16:10:00 -0000 Message-Id: <83mvrjytyx.fsf@gnu.org> From: Eli Zaretskii To: Doug Evans CC: gdb-patches@sourceware.org In-reply-to: <94eb2c0b86103073b2052abf11e5@google.com> (message from Doug Evans on Tue, 02 Feb 2016 01:03:19 +0000) Subject: Re: [PATCH, doc RFA] Add "skip regexp" Reply-to: Eli Zaretskii References: <94eb2c0b86103073b2052abf11e5@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00060.txt.bz2 > Date: Tue, 02 Feb 2016 01:03:19 +0000 > From: Doug Evans > > With this patch one can specify the skip as: > > skip regexp ^std::(allocator|basic_string)<.*>::~?\1 *\( Thanks. > 2016-02-01 Doug Evans > > New command "skip regexp regular-expression". > * NEWS: Document the new feature. > * skip.c (skip_kind): New enum. > (skiplist_entry) : Delete. > : New members. > (skiplist_entry_kind_name): New function. > (make_skip_file, make_skip_function, make_skip_regexp): New function. > (free_skiplist_entry, free_skiplist_entry_cleanup): New functions. > (make_free_skiplist_entry_cleanup): New function. > (skip_file_command): Update. > (skip_function): Update. > (compile_skip_regexp, skip_regexp_command): New functions. > (skip_info): Update. > (sal_and_fullname): New struct. > (skip_file_p, skip_function_p, skip_regexp_p): New functions. > (function_name_is_marked_for_skip): Update and simplify. > (_initialize_step_skip): Add "skip regexp" command. > > doc/ > * gdb.texinfo (Skipping Over Functions and Files): Document > "skip regexp". The documentation parts are approved, with the following nit: > +Functions may be skipped by providing either a function name, linespec > +(@pxref{Specify Location}), file name, or regular expression of the > +function's name. ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ "regular expression that matches the function's name" is more accurate (and you also use it elsewhere in the patch). Otherwise, fine with me, thanks.