From: Eli Zaretskii <eliz@gnu.org>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/6] New commands for loading and unloading a reader.
Date: Sat, 20 Aug 2011 08:24:00 -0000 [thread overview]
Message-ID: <83liuoqymn.fsf@gnu.org> (raw)
In-Reply-To: <1313821635-22137-4-git-send-email-sanjoy@playingwithpointers.com>
> From: Sanjoy Das <sanjoy@playingwithpointers.com>
> Cc: Sanjoy Das <sanjoy@playingwithpointers.com>
> Date: Sat, 20 Aug 2011 11:57:12 +0530
>
> + add_com ("load-jit-reader", no_class, load_jit_reader_command, _("\
> +Try to load file FILE as a debug info reader (and unwinder) for\n\
> +JIT compiled code from " LIBDIR "/gdb\n\
> +Usage is `load-jit-reader FILE`."));
The first line of a doc string should be a complete sentence, because
it is displayed by help commands such as apropos. I suggest
Load FILE as debug info reader and unwinder for JIT compiled code.
Then you can have the more detailed information in the rest of the doc
string.
> + add_com ("unload-jit-reader", no_class, unload_jit_reader_command, _("\
> +Unload the currently loaded JIT reader (loaded using load-jit-reader)\n\
> +Usage is `unload-jit-reader`."));
The reference to load-jit-reader in the first line looks redundant.
And the usage is trivial. How about this instead?
Unload the currently loaded JIT debug info reader.
See load-jit-reader for how to load JIT debug readers.
Thanks.
next prev parent reply other threads:[~2011-08-20 8:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 6:26 JIT Reader (re-roll) Sanjoy Das
2011-08-20 6:26 ` [PATCH 1/6] Introduce header (jit-reader.in) and modify build system Sanjoy Das
2011-08-20 18:04 ` Jan Kratochvil
2011-08-20 18:18 ` Sanjoy Das
2011-08-20 6:27 ` [PATCH 5/6] New JIT unwinder Sanjoy Das
2011-08-20 17:59 ` Jan Kratochvil
2011-08-20 18:30 ` Mark Kettenis
2011-08-20 19:45 ` Jan Kratochvil
2011-08-30 17:53 ` Tom Tromey
2011-08-20 6:27 ` [PATCH 3/6] New commands for loading and unloading a reader Sanjoy Das
2011-08-20 8:24 ` Eli Zaretskii [this message]
2011-08-20 17:31 ` Jan Kratochvil
2011-08-20 6:27 ` [PATCH 2/6] Platform agnostic dynamic loading code Sanjoy Das
2011-08-20 6:33 ` [PATCH 4/6] Use the loaded reader Sanjoy Das
2011-08-20 6:33 ` [PATCH 6/6] Documentation Sanjoy Das
2011-08-20 8:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83liuoqymn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox