From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83132-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8925 invoked by alias); 20 Aug 2011 08:24:40 -0000
Received: (qmail 8917 invoked by uid 22791); 20 Aug 2011 08:24:38 -0000
X-SWARE-Spam-Status: No, hits=0.5 required=5.0	tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Aug 2011 08:24:14 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LQ700K00WERT900@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 20 Aug 2011 11:24:13 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.126.49.191]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LQ7007RXWOB03YK@a-mtaout22.012.net.il>; Sat, 20 Aug 2011 11:24:12 +0300 (IDT)
Date: Sat, 20 Aug 2011 08:24:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 3/6] New commands for loading and unloading a reader.
In-reply-to: <1313821635-22137-4-git-send-email-sanjoy@playingwithpointers.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83liuoqymn.fsf@gnu.org>
References: <1313821635-22137-1-git-send-email-sanjoy@playingwithpointers.com> <1313821635-22137-4-git-send-email-sanjoy@playingwithpointers.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00392.txt.bz2

> From: Sanjoy Das <sanjoy@playingwithpointers.com>
> Cc: Sanjoy Das <sanjoy@playingwithpointers.com>
> Date: Sat, 20 Aug 2011 11:57:12 +0530
> 
> +  add_com ("load-jit-reader", no_class, load_jit_reader_command, _("\
> +Try to load file FILE as a debug info reader (and unwinder) for\n\
> +JIT compiled code from " LIBDIR "/gdb\n\
> +Usage is `load-jit-reader FILE`."));

The first line of a doc string should be a complete sentence, because
it is displayed by help commands such as apropos.  I suggest

 Load FILE as debug info reader and unwinder for JIT compiled code.

Then you can have the more detailed information in the rest of the doc
string.

> +  add_com ("unload-jit-reader", no_class, unload_jit_reader_command, _("\
> +Unload the currently loaded JIT reader (loaded using load-jit-reader)\n\
> +Usage is `unload-jit-reader`."));

The reference to load-jit-reader in the first line looks redundant.
And the usage is trivial.  How about this instead?

 Unload the currently loaded JIT debug info reader.
 See load-jit-reader for how to load JIT debug readers.

Thanks.