Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/6] Introduce header (jit-reader.in) and modify build system.
Date: Sat, 20 Aug 2011 18:04:00 -0000	[thread overview]
Message-ID: <20110820180354.GD26447@host1.jankratochvil.net> (raw)
In-Reply-To: <1313821635-22137-2-git-send-email-sanjoy@playingwithpointers.com>

On Sat, 20 Aug 2011 08:27:10 +0200, Sanjoy Das wrote:
> --- /dev/null
> +++ b/gdb/jit-reader.in
> @@ -0,0 +1,349 @@
[...]
> +/* Called when the reader is loaded. Must either return a properly
> +   populated gdb_reader_funcs or NULL. The memory allocated for the
> +   gdb_reader_funcs is to be managed by the reader itself (i.e. if it
> +   is allocated from the heap, it must also be freed in
> +   gdb_destroy_reader).  */
> +
> +extern struct gdb_reader_funcs *gdb_init_reader (void);

I think it should be:
extern const struct gdb_reader_funcs *gdb_init_reader (void);

as GDB should never modify it.


Thanks,
Jan


  reply	other threads:[~2011-08-20 18:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20  6:26 JIT Reader (re-roll) Sanjoy Das
2011-08-20  6:26 ` [PATCH 1/6] Introduce header (jit-reader.in) and modify build system Sanjoy Das
2011-08-20 18:04   ` Jan Kratochvil [this message]
2011-08-20 18:18     ` Sanjoy Das
2011-08-20  6:27 ` [PATCH 5/6] New JIT unwinder Sanjoy Das
2011-08-20 17:59   ` Jan Kratochvil
2011-08-20 18:30     ` Mark Kettenis
2011-08-20 19:45       ` Jan Kratochvil
2011-08-30 17:53         ` Tom Tromey
2011-08-20  6:27 ` [PATCH 2/6] Platform agnostic dynamic loading code Sanjoy Das
2011-08-20  6:27 ` [PATCH 3/6] New commands for loading and unloading a reader Sanjoy Das
2011-08-20  8:24   ` Eli Zaretskii
2011-08-20 17:31   ` Jan Kratochvil
2011-08-20  6:33 ` [PATCH 4/6] Use the loaded reader Sanjoy Das
2011-08-20  6:33 ` [PATCH 6/6] Documentation Sanjoy Das
2011-08-20  8:34   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110820180354.GD26447@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sanjoy@playingwithpointers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox