From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25614 invoked by alias); 20 Aug 2011 18:04:11 -0000 Received: (qmail 25606 invoked by uid 22791); 20 Aug 2011 18:04:11 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Aug 2011 18:03:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7KI3v1x027287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 20 Aug 2011 14:03:57 -0400 Received: from host1.jankratochvil.net (ovpn-116-42.ams2.redhat.com [10.36.116.42]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7KI3ts0003432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 20 Aug 2011 14:03:56 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7KI3s0C004108; Sat, 20 Aug 2011 20:03:54 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7KI3s5v004107; Sat, 20 Aug 2011 20:03:54 +0200 Date: Sat, 20 Aug 2011 18:04:00 -0000 From: Jan Kratochvil To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Introduce header (jit-reader.in) and modify build system. Message-ID: <20110820180354.GD26447@host1.jankratochvil.net> References: <1313821635-22137-1-git-send-email-sanjoy@playingwithpointers.com> <1313821635-22137-2-git-send-email-sanjoy@playingwithpointers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1313821635-22137-2-git-send-email-sanjoy@playingwithpointers.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00400.txt.bz2 On Sat, 20 Aug 2011 08:27:10 +0200, Sanjoy Das wrote: > --- /dev/null > +++ b/gdb/jit-reader.in > @@ -0,0 +1,349 @@ [...] > +/* Called when the reader is loaded. Must either return a properly > + populated gdb_reader_funcs or NULL. The memory allocated for the > + gdb_reader_funcs is to be managed by the reader itself (i.e. if it > + is allocated from the heap, it must also be freed in > + gdb_destroy_reader). */ > + > +extern struct gdb_reader_funcs *gdb_init_reader (void); I think it should be: extern const struct gdb_reader_funcs *gdb_init_reader (void); as GDB should never modify it. Thanks, Jan