Re: Building the 7.8.90 pretest on MinGW

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu, 15 Jan 2015 11:49:06 -0800
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches <gdb-patches@sourceware.org>
> 
> On Thu, Jan 15, 2015 at 8:07 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > I've built the pretest using MinGW32.  I found 2 issues: one with
> > gnulib's time.h (reported to the gnulib list), the other with the
> > recent changes in tui/.  Specifically, starting "gdb -tui" fails with
> > this error message:
> >
> >      Cannot enable the TUI: error opening terminal [TERM=<unset>]
> >
> > This happens because the recent additions to tui.c make assumptions
> > about the curses library that don't hold for the MinGW port of
> > ncurses, e.g. that $TERM must be set.
> >
> > The patch below fixes this for me.  OK to install it (master and
> > branch)?
> >
> > 2015-01-15  Eli Zaretskii  <eliz@gnu.org>
> >
> >         * gdb/tui/tui.c (tui_enable) [__MINGW32__]: If the call to 'newterm'
> >         fails with the 1st arg NULL, try again with "unknown".  Don't test
> >         the "cup" capability: it isn't supported by the Windows port of
> >         ncurses, but the Windows console driver is still capable of
> >         supporting TUI.
> 
> Ok by me.

Thanks.  I'd like to hear from Pedro as well, as the changes which
caused this were committed by him.