Re: Building the 7.8.90 pretest on MinGW

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu, 22 Jan 2015 11:05:09 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> Sorry for the delay.
> 
> On 01/19/2015 05:48 PM, Eli Zaretskii wrote:
> 
> > Thanks.  I'd like to hear from Pedro as well, as the changes which
> > caused this were committed by him.
> 
> This is OK with me.

Thanks, I will push shortly.

> A couple questions though:
> 
> The "cup" check is there to make sure that e.g., starting GDB
> in a shell within emacs doesn't result in a messed up session.
> Did you try that?

You mean, start GDB under Emacs as

   gdb -tui -i=mi ...

?  It's a strange thing to do, but I did try it now, and didn't see
any problems.  Which isn't surprising: Emacs injects "TERM=emacs" into
the environment inherited by GDB, so the Windows ncurses driver
doesn't activate itself.

> I imagine that cases like when stdin is a pipe, like e.g., when
> starting mingw gdb in a cygwin shell or in a cygwin ssh session, may
> result in a messed up screen.

Why would it? pipes fail the isatty test.

> I mildly wonder whether pdcurses works here as is without
> this patch, thus whether the #ifdef check should distinguish
> ncurses from pdcurses somehow.

I have no idea, ncurses seems to be much more actively developed than
pdcurses, so I switched long ago.

> IIUC, some people build with pdcurses instead of GNU ncurses.

Indeed, so I hope they will speak up.