From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119192-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22324 invoked by alias); 19 Jan 2015 17:48:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22113 invoked by uid 89); 19 Jan 2015 17:48:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jan 2015 17:48:22 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NIF00M00QKW1D00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 19 Jan 2015 19:48:19 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIF00LS1QSIUG50@a-mtaout22.012.net.il>; Mon, 19 Jan 2015 19:48:19 +0200 (IST)
Date: Mon, 19 Jan 2015 17:48:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Building the 7.8.90 pretest on MinGW
In-reply-to: <CADPb22TWRH+EBxr6i_kKX2NuVy9Gczo3v=FUWQGOFZqD9SpELA@mail.gmail.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83lhkyy84l.fsf@gnu.org>
References: <announce.20150113122445.36DDE48E8A@joel.gnat.com> <83vbk82fkg.fsf@gnu.org> <CADPb22TWRH+EBxr6i_kKX2NuVy9Gczo3v=FUWQGOFZqD9SpELA@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00526.txt.bz2

> Date: Thu, 15 Jan 2015 11:49:06 -0800
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches <gdb-patches@sourceware.org>
> 
> On Thu, Jan 15, 2015 at 8:07 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > I've built the pretest using MinGW32.  I found 2 issues: one with
> > gnulib's time.h (reported to the gnulib list), the other with the
> > recent changes in tui/.  Specifically, starting "gdb -tui" fails with
> > this error message:
> >
> >      Cannot enable the TUI: error opening terminal [TERM=<unset>]
> >
> > This happens because the recent additions to tui.c make assumptions
> > about the curses library that don't hold for the MinGW port of
> > ncurses, e.g. that $TERM must be set.
> >
> > The patch below fixes this for me.  OK to install it (master and
> > branch)?
> >
> > 2015-01-15  Eli Zaretskii  <eliz@gnu.org>
> >
> >         * gdb/tui/tui.c (tui_enable) [__MINGW32__]: If the call to 'newterm'
> >         fails with the 1st arg NULL, try again with "unknown".  Don't test
> >         the "cup" capability: it isn't supported by the Windows port of
> >         ncurses, but the Windows console driver is still capable of
> >         supporting TUI.
> 
> Ok by me.

Thanks.  I'd like to hear from Pedro as well, as the changes which
caused this were committed by him.