Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: "Invalid parameter passed to C runtime function" from MinGW GDB
Date: Tue, 20 Nov 2018 16:54:00 -0000	[thread overview]
Message-ID: <83lg5nitay.fsf@gnu.org> (raw)
In-Reply-To: <874lccpvra.fsf@tromey.com> (message from Tom Tromey on Mon, 19	Nov 2018 15:06:49 -0700)

> From: Tom Tromey <tom@tromey.com>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 19 Nov 2018 15:06:49 -0700
> 
> Eli> diff --git a/gdb/common/filestuff.c b/gdb/common/filestuff.c
> Eli> index d4bd1a8..3fa035a 100644
> Eli> --- a/gdb/common/filestuff.c
> Eli> +++ b/gdb/common/filestuff.c
> Eli> @@ -300,8 +300,10 @@ gdb_fopen_cloexec (const char *filename, const char *opentype)
> Eli>       skip it.  E.g., the Windows runtime issues an "Invalid parameter
> Eli>       passed to C runtime function" OutputDebugString warning for
> Eli>       unknown modes.  Assume that if O_CLOEXEC is zero, then "e" isn't
> Eli> -     supported.  */
> Eli> -  static int fopen_e_ever_failed_einval = O_CLOEXEC == 0;
> Eli> +     supported.  On MinGW, O_CLOEXEC is an alias of O_NOINHERIT, and
> Eli> +     "e" isn't supported.  */
> Eli> +  static int fopen_e_ever_failed_einval =
> Eli> +    O_CLOEXEC == 0 || O_CLOEXEC == O_NOINHERIT;
> 
> Looks reasonable to me, thanks.

Thanks, pushed to master.  (Sorry for an empty message I sent by
mistake a few minutes ago.)


      parent reply	other threads:[~2018-11-20 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-18 16:46 Eli Zaretskii
2018-11-19 22:06 ` Tom Tromey
2018-11-20 16:52   ` Eli Zaretskii
2018-11-20 16:54   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lg5nitay.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox