From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85413 invoked by alias); 20 Nov 2018 16:54:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85390 invoked by uid 89); 20 Nov 2018 16:54:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=U*gdb-patches, gdbpatchessourcewareorg, sk:gdb-pat, gdb-patches@sourceware.org X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Nov 2018 16:54:00 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP9Hb-00010x-BL for gdb-patches@sourceware.org; Tue, 20 Nov 2018 11:53:55 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP9HY-0000zk-7r; Tue, 20 Nov 2018 11:53:49 -0500 Received: from [176.228.60.248] (port=3532 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gP9HX-00030u-SP; Tue, 20 Nov 2018 11:53:48 -0500 Date: Tue, 20 Nov 2018 16:54:00 -0000 Message-Id: <83lg5nitay.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <874lccpvra.fsf@tromey.com> (message from Tom Tromey on Mon, 19 Nov 2018 15:06:49 -0700) Subject: Re: "Invalid parameter passed to C runtime function" from MinGW GDB References: <838t1qtjty.fsf@gnu.org> <874lccpvra.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00319.txt.bz2 > From: Tom Tromey > Cc: gdb-patches@sourceware.org > Date: Mon, 19 Nov 2018 15:06:49 -0700 > > Eli> diff --git a/gdb/common/filestuff.c b/gdb/common/filestuff.c > Eli> index d4bd1a8..3fa035a 100644 > Eli> --- a/gdb/common/filestuff.c > Eli> +++ b/gdb/common/filestuff.c > Eli> @@ -300,8 +300,10 @@ gdb_fopen_cloexec (const char *filename, const char *opentype) > Eli> skip it. E.g., the Windows runtime issues an "Invalid parameter > Eli> passed to C runtime function" OutputDebugString warning for > Eli> unknown modes. Assume that if O_CLOEXEC is zero, then "e" isn't > Eli> - supported. */ > Eli> - static int fopen_e_ever_failed_einval = O_CLOEXEC == 0; > Eli> + supported. On MinGW, O_CLOEXEC is an alias of O_NOINHERIT, and > Eli> + "e" isn't supported. */ > Eli> + static int fopen_e_ever_failed_einval = > Eli> + O_CLOEXEC == 0 || O_CLOEXEC == O_NOINHERIT; > > Looks reasonable to me, thanks. Thanks, pushed to master. (Sorry for an empty message I sent by mistake a few minutes ago.)