Re: "Invalid parameter passed to C runtime function" from MinGW GDB

[Tom Tromey <tom@tromey.com>]

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> I propose to fix this as below.  Any objections to committing this to
Eli> master (with a suitable ChangeLog, of course)? 

Eli> diff --git a/gdb/common/filestuff.c b/gdb/common/filestuff.c
Eli> index d4bd1a8..3fa035a 100644
Eli> --- a/gdb/common/filestuff.c
Eli> +++ b/gdb/common/filestuff.c
Eli> @@ -300,8 +300,10 @@ gdb_fopen_cloexec (const char *filename, const char *opentype)
Eli>       skip it.  E.g., the Windows runtime issues an "Invalid parameter
Eli>       passed to C runtime function" OutputDebugString warning for
Eli>       unknown modes.  Assume that if O_CLOEXEC is zero, then "e" isn't
Eli> -     supported.  */
Eli> -  static int fopen_e_ever_failed_einval = O_CLOEXEC == 0;
Eli> +     supported.  On MinGW, O_CLOEXEC is an alias of O_NOINHERIT, and
Eli> +     "e" isn't supported.  */
Eli> +  static int fopen_e_ever_failed_einval =
Eli> +    O_CLOEXEC == 0 || O_CLOEXEC == O_NOINHERIT;

Looks reasonable to me, thanks.

Tom