Re: [RFC] info threads takes an argument

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 14 Feb 2011 11:54:11 -0800
> From: Michael Snyder <msnyder@vmware.com>
> 
> Documentation and NEWS also attached.

Thanks.

> +	  printf_filtered ("Thread %d has name '%s'\n", tp->num, tp->name);

No _() (here and elsewhere in this function)?

>  *** Changes since GDB 7.2
>  
> +* GDB has a new command: "thread find [regexp]".
> +  It finds the thread id whose name, target id, or thread extra info
> +  matches the given regular expression.
> +

This part is okay.

> +@item info threads @r{[}@var{ids}@r{]}
> +Display a summary of all threads currently in your program.  Optional 
> +argument @var{ids} means print information only about the specified
> +thread or threads.

We should say what is the syntax if @var{ids}.  IIUC,
"@var{id}@dots{}" is a better way of expressing it (but still,
something should be said about the valid syntax, e.g. can I use
"23-32"?)

> +Search for and display thread ids whose name, target thread id, or 
> +target extra info matches the supplied regular expression.

What you call "extra info" and "target thread id" is described under
different names just a few dozen lines above this text.  Let's use a
consistent terminology, to avoid confusion, okay?

> +As well as being the complement to the @samp{thread name} command, 
> +this command also allows you to identify a thread by its target thread
> +id.  For instance, on Linux, the target thread id is the LWP id.
                         ^^^^^
"GNU/Linux", right?

Okay with those changes.