From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 853 invoked by alias); 14 Feb 2011 20:18:07 -0000 Received: (qmail 826 invoked by uid 22791); 14 Feb 2011 20:18:06 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Feb 2011 20:17:58 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LGM00300IYC7V00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 14 Feb 2011 22:17:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.171.5]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LGM003GYJ160J30@a-mtaout22.012.net.il>; Mon, 14 Feb 2011 22:17:32 +0200 (IST) Date: Mon, 14 Feb 2011 20:40:00 -0000 From: Eli Zaretskii Subject: Re: [RFC] info threads takes an argument In-reply-to: <4D598863.1030507@vmware.com> To: Michael Snyder Cc: tromey@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83k4h2pe03.fsf@gnu.org> References: <4D54964A.2070401@vmware.com> <20110211060855.GT2384@adacore.com> <4D558CA9.7070302@vmware.com> <4D55B1ED.5020808@vmware.com> <4D598863.1030507@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00298.txt.bz2 > Date: Mon, 14 Feb 2011 11:54:11 -0800 > From: Michael Snyder > > Documentation and NEWS also attached. Thanks. > + printf_filtered ("Thread %d has name '%s'\n", tp->num, tp->name); No _() (here and elsewhere in this function)? > *** Changes since GDB 7.2 > > +* GDB has a new command: "thread find [regexp]". > + It finds the thread id whose name, target id, or thread extra info > + matches the given regular expression. > + This part is okay. > +@item info threads @r{[}@var{ids}@r{]} > +Display a summary of all threads currently in your program. Optional > +argument @var{ids} means print information only about the specified > +thread or threads. We should say what is the syntax if @var{ids}. IIUC, "@var{id}@dots{}" is a better way of expressing it (but still, something should be said about the valid syntax, e.g. can I use "23-32"?) > +Search for and display thread ids whose name, target thread id, or > +target extra info matches the supplied regular expression. What you call "extra info" and "target thread id" is described under different names just a few dozen lines above this text. Let's use a consistent terminology, to avoid confusion, okay? > +As well as being the complement to the @samp{thread name} command, > +this command also allows you to identify a thread by its target thread > +id. For instance, on Linux, the target thread id is the LWP id. ^^^^^ "GNU/Linux", right? Okay with those changes.