Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] info threads takes an argument
Date: Fri, 11 Feb 2011 06:09:00 -0000	[thread overview]
Message-ID: <20110211060855.GT2384@adacore.com> (raw)
In-Reply-To: <4D54964A.2070401@vmware.com>

> 2011-02-10  Michael Snyder  <msnyder@msnyder-server.eng.vmware.com>
> 
> 	* thread.c (info_threads_command): Process arg as thread id.

This seems like a reasonable enhancement to me. We have the same sort
of feature for Ada (except that we print a more detailed description
of the given task).

You will also need a documentation update...

> +  if (arg != NULL && *arg != '\0')
> +    {
> +      int tmp_tid = strtoul (arg, NULL, 0);
> +      if (tmp_tid != 0)

Emtpy line after the variable declaration...

-- 
Joel


  reply	other threads:[~2011-02-11  6:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11  1:52 Michael Snyder
2011-02-11  6:09 ` Joel Brobecker [this message]
2011-02-11 19:23   ` Michael Snyder
2011-02-11 21:14     ` Tom Tromey
     [not found]       ` <4D55B1ED.5020808@vmware.com>
     [not found]         ` <m3k4h2e6xu.fsf@fleche.redhat.com>
2011-02-14 20:03           ` Michael Snyder
2011-02-14 20:40             ` Eli Zaretskii
2011-02-15 19:58             ` Tom Tromey
2011-02-15 21:44               ` Michael Snyder
2011-02-16 11:58                 ` Pedro Alves
2011-02-16 18:47                   ` Michael Snyder
2011-02-17 16:57                     ` Jan Kratochvil
2011-02-17 19:12                       ` Michael Snyder
2011-02-17 20:11                       ` Michael Snyder
2011-02-17 21:22                         ` Jan Kratochvil
2011-02-21 18:45                 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110211060855.GT2384@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox