Re: [PATCH] dynamic printf

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 28 Feb 2012 23:03:49 -0800
> From: Stan Shebs <stanshebs@earthlink.net>
> 
> This patch implements a "dynamic printf", which is basically a 
> breakpoint with a printf;continue as its command list - but with 
> additional features that make it more interesting.

Thanks.  I cannot say I like the name, though: the "dynamic" part has
no mnemonic value at all.

> +  add_cmd ("agent-printf", class_maintenance, agent_printf_command,
> +	   _("Translate an expression into remote "
> +	     "agent bytecode for evaluation."),
> +	   &maintenancelist);

This new command seems to be undocumented.

> +  add_setshow_enum_cmd ("dprintf-style", class_support,
> +			dprintf_style_enums, &dprintf_style, _("\
> +Set the style of usage for dynamic printf."), _("\
> +Show the style of usage for dynamic printf."), _("\
> +Choose the style of usage for dynamic printf.\n\

How about listing the available styles with one line of description
for each one?

> +@item call
> +@kindex dprintf-style call
> +Handle the output by calling your program's @code{printf} function.
> +(This expects @code{printf} to have been linked into the program.)

And what happens if it isn't?

This needs a NEWS entry.

Thanks.