Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] dynamic printf
Date: Wed, 14 Mar 2012 15:28:00 -0000	[thread overview]
Message-ID: <87d38fdwy3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F5FD3A6.1090106@earthlink.net> (Stan Shebs's message of "Tue,	13 Mar 2012 16:09:26 -0700")

>>>>> "Stan" == Stan Shebs <stanshebs@earthlink.net> writes:

Stan> Another consideration is how the collection looks in an info break
Stan> command.  If dynamic prints are a different kind of breakpoint, then
Stan> you can (in theory) filter the breakpoint listing to a single
Stan> category, but if they are just breakpoints with special commands,
Stan> they'll continue to be in the big list.

I tend to prefer a new command for this reason and also KISS.

Stan> My intuition isn't giving me a strong read on which approach users
Stan> will like better.  As the goal is at least partly to entice
Stan> printf()+recompile users into using a GDB command instead, I think it
Stan> needs to be among GDB's simpler commands.  Maybe include both
Stan> syntaxes, mapping down to same functionality?

dprintf breakpoints have different semantics from regular breakpoints,
too, don't they?  They are non-stopping.

It seems to me that if you go the suffix route, then you also need ways
to control the stopping-ness, and to change or delete the printf stuff.

I think it is simpler and hardly any less convenient for users to just
have dprintf and regular breakpoints be separate things.

If we get a flood of bug reports to the contrary, we can always go back
and add the printf qualifier later.

Tom


  parent reply	other threads:[~2012-03-14 15:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29  9:14 Stan Shebs
2012-02-29 10:28 ` Andreas Schwab
2012-03-13 23:09   ` Stan Shebs
2012-03-14 14:47     ` Marc Khouzam
2012-03-14 15:28     ` Tom Tromey [this message]
2012-02-29 16:16 ` Joel Brobecker
2012-03-13 23:15   ` Stan Shebs
2012-03-13 23:40     ` Joel Brobecker
2012-02-29 18:21 ` Eli Zaretskii
2012-03-13 23:20   ` Stan Shebs
2012-03-01 14:04 ` Hui Zhu
2012-03-04  6:31   ` Hui Zhu
2012-03-08 21:08 ` Tom Tromey
2012-03-13 23:51   ` Stan Shebs
2012-03-14 15:24     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d38fdwy3.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=stanshebs@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox