From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88353-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10965 invoked by alias); 29 Feb 2012 18:20:17 -0000
Received: (qmail 10950 invoked by uid 22791); 29 Feb 2012 18:20:16 -0000
X-SWARE-Spam-Status: No, hits=-1.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 18:20:02 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M0600A002SNPV00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 29 Feb 2012 20:20:01 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.119.92]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M06007582XC98A1@a-mtaout22.012.net.il>; Wed, 29 Feb 2012 20:20:01 +0200 (IST)
Date: Wed, 29 Feb 2012 18:21:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] dynamic printf
In-reply-to: <4F4DCDD5.2040807@earthlink.net>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k435cxf3.fsf@gnu.org>
References: <4F4DCDD5.2040807@earthlink.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00725.txt.bz2

> Date: Tue, 28 Feb 2012 23:03:49 -0800
> From: Stan Shebs <stanshebs@earthlink.net>
> 
> This patch implements a "dynamic printf", which is basically a 
> breakpoint with a printf;continue as its command list - but with 
> additional features that make it more interesting.

Thanks.  I cannot say I like the name, though: the "dynamic" part has
no mnemonic value at all.

> +  add_cmd ("agent-printf", class_maintenance, agent_printf_command,
> +	   _("Translate an expression into remote "
> +	     "agent bytecode for evaluation."),
> +	   &maintenancelist);

This new command seems to be undocumented.

> +  add_setshow_enum_cmd ("dprintf-style", class_support,
> +			dprintf_style_enums, &dprintf_style, _("\
> +Set the style of usage for dynamic printf."), _("\
> +Show the style of usage for dynamic printf."), _("\
> +Choose the style of usage for dynamic printf.\n\

How about listing the available styles with one line of description
for each one?

> +@item call
> +@kindex dprintf-style call
> +Handle the output by calling your program's @code{printf} function.
> +(This expects @code{printf} to have been linked into the program.)

And what happens if it isn't?

This needs a NEWS entry.

Thanks.