From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org, marc.khouzam@ericsson.com
Subject: Re: [PATCH v2] Exit code of exited inferiors
Date: Wed, 29 May 2013 15:57:00 -0000 [thread overview]
Message-ID: <83k3mh6ant.fsf@gnu.org> (raw)
In-Reply-To: <51A5160D.40800@ericsson.com>
> Date: Tue, 28 May 2013 16:39:41 -0400
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Marc Khouzam <marc.khouzam@ericsson.com>
>
> This is the second version of my patch to add the exit-code in the
> -list-thread-groups output. New in v2: NEWS file, documentation and a
> test case. I didn't find any test about -list-thread-groups so I created it.
>
> As far as I know, this does not break any other test.
>
> Changelog:
>
> 2013-05-28 Simon Marchi <simon.marchi@ericsson.com>
>
> * gdb/NEWS: Announce new exit-code field.
> * gdb/doc/gdb.texinfo: Document new exit-code field.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
You should state the name of the node in which you made the change, as
if it were a function (i.e. in parentheses).
> * gdb/inferior.c (exit_inferior_1): Remove exit code clear.
> (inferior_appeared): Add exit code clear.
> * gdb/mi/mi-main.c (print_one_inferior): Add printing of the exit code.
> * gdb/testsuite/gdb.mi/mi-list.exp: New file, added test case for
> -list-thread-groups.
OK for the documentation part, after you have fixed the above gotcha.
Thanks.
next parent reply other threads:[~2013-05-29 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51A5160D.40800@ericsson.com>
2013-05-29 15:57 ` Eli Zaretskii [this message]
2013-05-29 16:02 ` Simon Marchi
2013-06-06 17:41 ` Pedro Alves
2013-06-06 18:34 ` Tom Tromey
2013-06-06 19:09 ` Simon Marchi
2013-06-17 16:13 ` Simon Marchi
2013-06-17 16:51 ` Pedro Alves
2013-06-17 18:42 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k3mh6ant.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox