Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, <gdb-patches@sourceware.org>,
	<marc.khouzam@ericsson.com>
Subject: Re: [PATCH v2] Exit code of exited inferiors
Date: Thu, 06 Jun 2013 19:09:00 -0000	[thread overview]
Message-ID: <51B0DDF2.2010602@ericsson.com> (raw)
In-Reply-To: <51B0BDBC.9030909@redhat.com>

> I didn't see exit-code.c in the patch though.  Did you forget to
> add it?

Oops, probably.

>> +    # Exit the inferior
>> +    mi_send_resuming_command "exec-continue" "continuing to exit inferior"
>> +    mi_expect_stop "exited-normally" "" "" "" "" "" "exiting inferior"
>> +
>> +    # Check after the run
>> +    mi_gdb_test "124-list-thread-groups" "124\\^done,groups=\\\[\{id=\"i1\",type=\"process\",exit-code=\"0\",executable=\".*\"\}\]" "test -list-thread-groups 3"
>> +
>> +    # Start the program again to get an other exit code
>
> "another".
>
>> +    mi_run_to_main 10
>
> What does this "10" do?

I thought I did, but apparently I didn't mention that this patch depends 
on this one, which adds the ability to pass arguments to mi_run_to_main 
that are passed to the test executable:
http://sourceware.org/ml/gdb-patches/2013-05/msg00971.html

That reminds me, I still need to produce an updated version of this 
other patch, following the comments I got.

Basically, exit-code.c (which, as you noted, I forgot to add to the 
patch) simply returns what you ask it to return (10 in this case).

> Thanks,

Ok for the rest of the comments, they are all relevant and useful.

Thanks,

Simon


  parent reply	other threads:[~2013-06-06 19:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51A5160D.40800@ericsson.com>
2013-05-29 15:57 ` Eli Zaretskii
2013-05-29 16:02   ` Simon Marchi
2013-06-06 17:41     ` Pedro Alves
2013-06-06 18:34       ` Tom Tromey
2013-06-06 19:09       ` Simon Marchi [this message]
2013-06-17 16:13       ` Simon Marchi
2013-06-17 16:51         ` Pedro Alves
2013-06-17 18:42           ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B0DDF2.2010602@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox