From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30571 invoked by alias); 6 Jun 2013 19:09:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30547 invoked by uid 89); 6 Jun 2013 19:09:16 -0000 X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,SPF_PASS autolearn=ham version=3.3.1 Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 06 Jun 2013 19:09:12 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 46.51.17537.75ED0B15; Thu, 6 Jun 2013 21:09:11 +0200 (CEST) Received: from eusaamw0712.eamcs.ericsson.se (147.117.20.181) by EUSAAHC007.ericsson.se (147.117.188.93) with Microsoft SMTP Server (TLS) id 14.2.328.9; Thu, 6 Jun 2013 15:09:10 -0400 Received: from [142.133.110.167] (147.117.20.214) by smtps-am.internal.ericsson.com (147.117.20.181) with Microsoft SMTP Server (TLS) id 8.3.279.1; Thu, 6 Jun 2013 15:09:10 -0400 Message-ID: <51B0DDF2.2010602@ericsson.com> Date: Thu, 06 Jun 2013 19:09:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Pedro Alves CC: Eli Zaretskii , , Subject: Re: [PATCH v2] Exit code of exited inferiors References: <51A5160D.40800@ericsson.com> <83k3mh6ant.fsf@gnu.org> <51A6263A.9080104@ericsson.com> <51B0BDBC.9030909@redhat.com> In-Reply-To: <51B0BDBC.9030909@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00132.txt.bz2 > I didn't see exit-code.c in the patch though. Did you forget to > add it? Oops, probably. >> + # Exit the inferior >> + mi_send_resuming_command "exec-continue" "continuing to exit inferior" >> + mi_expect_stop "exited-normally" "" "" "" "" "" "exiting inferior" >> + >> + # Check after the run >> + mi_gdb_test "124-list-thread-groups" "124\\^done,groups=\\\[\{id=\"i1\",type=\"process\",exit-code=\"0\",executable=\".*\"\}\]" "test -list-thread-groups 3" >> + >> + # Start the program again to get an other exit code > > "another". > >> + mi_run_to_main 10 > > What does this "10" do? I thought I did, but apparently I didn't mention that this patch depends on this one, which adds the ability to pass arguments to mi_run_to_main that are passed to the test executable: http://sourceware.org/ml/gdb-patches/2013-05/msg00971.html That reminds me, I still need to produce an updated version of this other patch, following the comments I got. Basically, exit-code.c (which, as you noted, I forgot to add to the patch) simply returns what you ask it to return (10 in this case). > Thanks, Ok for the rest of the comments, they are all relevant and useful. Thanks, Simon