From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101991-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21513 invoked by alias); 29 May 2013 15:57:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 21503 invoked by uid 89); 29 May 2013 15:57:49 -0000
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 15:57:48 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MNK00600HD53X00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 29 May 2013 18:57:45 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MNK0064DHO84W00@a-mtaout23.012.net.il>; Wed, 29 May 2013 18:57:45 +0300 (IDT)
Date: Wed, 29 May 2013 15:57:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2] Exit code of exited inferiors
In-reply-to: <51A5160D.40800@ericsson.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org, marc.khouzam@ericsson.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k3mh6ant.fsf@gnu.org>
References: <51A5160D.40800@ericsson.com>
X-SW-Source: 2013-05/txt/msg00997.txt.bz2

> Date: Tue, 28 May 2013 16:39:41 -0400
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Marc Khouzam <marc.khouzam@ericsson.com>
> 
> This is the second version of my patch to add the exit-code in the 
> -list-thread-groups output. New in v2: NEWS file, documentation and a 
> test case. I didn't find any test about -list-thread-groups so I created it.
> 
> As far as I know, this does not break any other test.
> 
> Changelog:
> 
> 2013-05-28  Simon Marchi  <simon.marchi@ericsson.com>
> 
>      * gdb/NEWS: Announce new exit-code field.
>      * gdb/doc/gdb.texinfo: Document new exit-code field.
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
You should state the name of the node in which you made the change, as
if it were a function (i.e. in parentheses).

>      * gdb/inferior.c (exit_inferior_1): Remove exit code clear.
>      (inferior_appeared): Add exit code clear.
>      * gdb/mi/mi-main.c (print_one_inferior): Add printing of the exit code.
>      * gdb/testsuite/gdb.mi/mi-list.exp: New file, added test case for
>          -list-thread-groups.

OK for the documentation part, after you have fixed the above gotcha.

Thanks.