* [djgpp/RFA] Fix crashes due to invalid numregs
@ 2009-04-30 19:10 Eli Zaretskii
2009-04-30 21:38 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2009-04-30 19:10 UTC (permalink / raw)
To: gdb-patches
This patch avoids internal_error's in the DJGPP port in places like
"finish", when GDB refills its regcache and tries to request too many
registers.
OK to commit?
2009-04-29 Eli Zaretskii <eliz@gnu.org>
* i386-tdep.c (i386_go32_init_abi): Override the number of
registers due to non-support of SSE.
--- i386-tdep.c~ 2009-02-17 10:14:16.000000000 +0200
+++ i386-tdep.c 2009-04-29 13:40:00.314875000 +0300
@@ -2594,6 +2594,10 @@
tdep->sigtramp_p = NULL;
tdep->jb_pc_offset = 36;
+
+ /* DJGPP does not support the SSE registers. */
+ tdep->num_xmm_regs = 0;
+ set_gdbarch_num_regs (gdbarch, I386_NUM_GREGS + I386_NUM_FREGS);
}
\f
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [djgpp/RFA] Fix crashes due to invalid numregs
2009-04-30 19:10 [djgpp/RFA] Fix crashes due to invalid numregs Eli Zaretskii
@ 2009-04-30 21:38 ` Mark Kettenis
2009-05-01 8:10 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2009-04-30 21:38 UTC (permalink / raw)
To: eliz; +Cc: gdb-patches
> Date: Thu, 30 Apr 2009 22:10:28 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> This patch avoids internal_error's in the DJGPP port in places like
> "finish", when GDB refills its regcache and tries to request too many
> registers.
>
> OK to commit?
Looks fine to me.
> 2009-04-29 Eli Zaretskii <eliz@gnu.org>
>
> * i386-tdep.c (i386_go32_init_abi): Override the number of
> registers due to non-support of SSE.
>
> --- i386-tdep.c~ 2009-02-17 10:14:16.000000000 +0200
> +++ i386-tdep.c 2009-04-29 13:40:00.314875000 +0300
> @@ -2594,6 +2594,10 @@
> tdep->sigtramp_p = NULL;
>
> tdep->jb_pc_offset = 36;
> +
> + /* DJGPP does not support the SSE registers. */
> + tdep->num_xmm_regs = 0;
> + set_gdbarch_num_regs (gdbarch, I386_NUM_GREGS + I386_NUM_FREGS);
> }
> \f
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [djgpp/RFA] Fix crashes due to invalid numregs
2009-04-30 21:38 ` Mark Kettenis
@ 2009-05-01 8:10 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2009-05-01 8:10 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
> Date: Thu, 30 Apr 2009 23:37:48 +0200 (CEST)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> CC: gdb-patches@sourceware.org
>
> > Date: Thu, 30 Apr 2009 22:10:28 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> >
> > This patch avoids internal_error's in the DJGPP port in places like
> > "finish", when GDB refills its regcache and tries to request too many
> > registers.
> >
> > OK to commit?
>
> Looks fine to me.
>
> > 2009-04-29 Eli Zaretskii <eliz@gnu.org>
> >
> > * i386-tdep.c (i386_go32_init_abi): Override the number of
> > registers due to non-support of SSE.
Thanks, committed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-01 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-30 19:10 [djgpp/RFA] Fix crashes due to invalid numregs Eli Zaretskii
2009-04-30 21:38 ` Mark Kettenis
2009-05-01 8:10 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox