Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
Cc: gdb-patches@sourceware.org
Subject: Re: [djgpp/RFA] Fix crashes due to invalid numregs
Date: Thu, 30 Apr 2009 21:38:00 -0000	[thread overview]
Message-ID: <200904302137.n3ULbmPt005631@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <83iqkmdkkb.fsf@gnu.org> (message from Eli Zaretskii on Thu, 30 	Apr 2009 22:10:28 +0300)

> Date: Thu, 30 Apr 2009 22:10:28 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> This patch avoids internal_error's in the DJGPP port in places like
> "finish", when GDB refills its regcache and tries to request too many
> registers.
> 
> OK to commit?

Looks fine to me.

> 2009-04-29  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* i386-tdep.c (i386_go32_init_abi): Override the number of
> 	registers due to non-support of SSE.
> 
> --- i386-tdep.c~	2009-02-17 10:14:16.000000000 +0200
> +++ i386-tdep.c	2009-04-29 13:40:00.314875000 +0300
> @@ -2594,6 +2594,10 @@
>    tdep->sigtramp_p = NULL;
>  
>    tdep->jb_pc_offset = 36;
> +
> +  /* DJGPP does not support the SSE registers.  */
> +  tdep->num_xmm_regs = 0;
> +  set_gdbarch_num_regs (gdbarch, I386_NUM_GREGS + I386_NUM_FREGS);
>  }
>  \f
>  
> 


  reply	other threads:[~2009-04-30 21:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30 19:10 Eli Zaretskii
2009-04-30 21:38 ` Mark Kettenis [this message]
2009-05-01  8:10   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904302137.n3ULbmPt005631@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox