From: Eli Zaretskii <eliz@gnu.org>
To: Ross Morley <ross@tensilica.com>
Cc: gdb-patches@sourceware.org, maxim@tensilica.com
Subject: Re: [PATCH] Program Breakpoints
Date: Wed, 22 Apr 2009 03:12:00 -0000 [thread overview]
Message-ID: <83hc0hgz5p.fsf@gnu.org> (raw)
In-Reply-To: <49EE7130.10505@tensilica.com>
> Date: Tue, 21 Apr 2009 18:21:52 -0700
> From: Ross Morley <ross@tensilica.com>
> CC: Maxim Grigoriev <maxim@tensilica.com>
>
> I've also incorporated Eli's feedback on the doc and NEWS (maybe I went
> a bit verbose on the NEWS, but you can tell me what to cut). I kept using
> the term "target" in the remote protocol section because it's common there.
>
> New patch attached, replaces previous.
Thanks. I have only one comment:
> +@item program-breakpoint
> +A program breakpoint (trap instruction unknown to @value{GDBN}) was reached.
This place is far from where you explained what a program breakpoint
is. So I suggest a cross-reference here to the node where program
breakpoints are described.
Sorry I didn't notice this in the original review.
Other than that, the patch for the manual is approved.
> Index: gdb/NEWS
This is fine.
next prev parent reply other threads:[~2009-04-22 3:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 1:51 [Fwd: [PATCH] Program Breakpoints] Ross Morley
2009-04-18 6:23 ` Eli Zaretskii
2009-04-22 1:22 ` [PATCH] Program Breakpoints Ross Morley
2009-04-22 3:12 ` Eli Zaretskii [this message]
2009-04-27 7:07 ` Ross Morley
-- strict thread matches above, loose matches on Subject: below --
2009-05-19 17:30 [Fwd: Re: [PATCH] Program Breakpoints] Ross Morley
2009-05-19 18:58 ` Pedro Alves
2009-05-27 1:49 ` [PATCH] Program Breakpoints Ross Morley
2009-04-30 18:05 Ross Morley
2009-04-30 18:30 ` Pedro Alves
2009-04-30 19:14 ` Ross Morley
2009-05-04 22:49 ` Ross Morley
2009-05-04 23:14 ` Pedro Alves
2009-05-04 23:17 ` Ross Morley
2009-05-13 4:24 ` Ross Morley
2009-04-18 1:33 Ross Morley
2009-04-18 6:21 ` Eli Zaretskii
2009-04-18 6:30 ` Eli Zaretskii
2009-04-18 7:58 ` Ross Morley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83hc0hgz5p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=maxim@tensilica.com \
--cc=ross@tensilica.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox