From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63187-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 612 invoked by alias); 22 Apr 2009 03:12:06 -0000
Received: (qmail 600 invoked by uid 22791); 22 Apr 2009 03:12:05 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_JMF_BR,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 03:11:59 +0000
Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KIH00B00FEJXJ00@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Wed, 22 Apr 2009 06:11:55 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.228.219.161]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KIH00IF9FJUUUA0@i-mtaout6.012.net.il>; Wed, 22 Apr 2009 06:11:55 +0300 (IDT)
Date: Wed, 22 Apr 2009 03:12:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Program Breakpoints
In-reply-to: <49EE7130.10505@tensilica.com>
To: Ross Morley <ross@tensilica.com>
Cc: gdb-patches@sourceware.org, maxim@tensilica.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83hc0hgz5p.fsf@gnu.org>
References: <49E93221.7010502@tensilica.com> <49EE7130.10505@tensilica.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-04/txt/msg00581.txt.bz2

> Date: Tue, 21 Apr 2009 18:21:52 -0700
> From: Ross Morley <ross@tensilica.com>
> CC: Maxim Grigoriev <maxim@tensilica.com>
> 
> I've also incorporated Eli's feedback on the doc and NEWS (maybe I went
> a bit verbose on the NEWS, but you can tell me what to cut). I kept using
> the term "target" in the remote protocol section because it's common there.
> 
> New patch attached, replaces previous.

Thanks.  I have only one comment:

> +@item program-breakpoint
> +A program breakpoint (trap instruction unknown to @value{GDBN}) was reached.

This place is far from where you explained what a program breakpoint
is.  So I suggest a cross-reference here to the node where program
breakpoints are described.

Sorry I didn't notice this in the original review.

Other than that, the patch for the manual is approved.

> Index: gdb/NEWS

This is fine.