Re: [PATCH] Program Breakpoints

[Ross Morley <ross@tensilica.com>]

Thanks for approving the doc. I will add the cross reference as you suggest
after the code is reviewed in case other changes are needed.

Still waiting for code review.

Ross


Eli Zaretskii wrote:

>>Date: Tue, 21 Apr 2009 18:21:52 -0700
>>From: Ross Morley <ross@tensilica.com>
>>CC: Maxim Grigoriev <maxim@tensilica.com>
>>
>>I've also incorporated Eli's feedback on the doc and NEWS (maybe I went
>>a bit verbose on the NEWS, but you can tell me what to cut). I kept using
>>the term "target" in the remote protocol section because it's common there.
>>
>>New patch attached, replaces previous.
>>    
>>
>
>Thanks.  I have only one comment:
>
>  
>
>>+@item program-breakpoint
>>+A program breakpoint (trap instruction unknown to @value{GDBN}) was reached.
>>    
>>
>
>This place is far from where you explained what a program breakpoint
>is.  So I suggest a cross-reference here to the node where program
>breakpoints are described.
>
>Sorry I didn't notice this in the original review.
>
>Other than that, the patch for the manual is approved.
>
>  
>
>>Index: gdb/NEWS
>>    
>>
>
>This is fine.
>
>  
>